Skip to content

Overhaul logging integration. - #123

Merged
Alex Milstead (amilstead) merged 2 commits into
masterfrom
amilstead/logging-overhaul
Jun 4, 2018
Merged

Overhaul logging integration.#123
Alex Milstead (amilstead) merged 2 commits into
masterfrom
amilstead/logging-overhaul

Conversation

@amilstead

@amilstead Alex Milstead (amilstead) commented Jun 1, 2018

Copy link
Copy Markdown
Contributor
  • Update README to reflect more modern install conventions.
  • Refactor SimpleLogger/NoOpLogger to use standard python logging.
  • Update tests.

Alex Milstead
Overhaul logging integration.
488c741 
Summary:
* Update README to reflect more modern install conventions.
* Refactor SimpleLogger/NoOpLogger to use standard python logging.
* Update tests.

Test Plan: CI

Reviewers: ali

Differential Revision: https://phabricator.optimizely.com/D19843
@coveralls

Coveralls (coveralls) commented Jun 4, 2018 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.002%) to 99.649% when pulling 24138db on amilstead/logging-overhaul into cca95a6 on master.

aliabbasrizvi
Ali Abbas Rizvi (aliabbasrizvi) approved these changes Jun 4, 2018
View reviewed changes

@aliabbasrizvi Ali Abbas Rizvi (aliabbasrizvi) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amilstead
Alex Milstead (amilstead) merged commit ed98b85 into master Jun 4, 2018
@amilstead
Alex Milstead (amilstead) deleted the amilstead/logging-overhaul branch June 4, 2018 19:10
This was referenced Jan 7, 2019
Closed
Merged
@oakbani Owais Akbani (oakbani) mentioned this pull request Mar 21, 2019
Merged
@asaschachar Asa Schachar (asaschachar) mentioned this pull request Apr 10, 2019
Merged
This was referenced Jul 5, 2019
Merged
Merged
This was referenced Jul 19, 2019
Closed
Merged
This was referenced Aug 1, 2019
Open
Open
@mnoman09 Muhammad Noman (mnoman09) mentioned this pull request Aug 16, 2019
Merged
This was referenced Sep 12, 2019
Merged
Merged
@oakbani Owais Akbani (oakbani) mentioned this pull request Oct 4, 2019
Merged
@oakbani Owais Akbani (oakbani) mentioned this pull request Dec 6, 2019
Merged
Merged
@juancarlostong JC (juancarlostong) mentioned this pull request Feb 7, 2020
Merged
@yavorona Polina Nguen (yavorona) mentioned this pull request May 14, 2020
Merged
@oakbani Owais Akbani (oakbani) mentioned this pull request Jul 13, 2020
Merged
@AmnaEjaz Amna Ejaz (AmnaEjaz) mentioned this pull request Jul 16, 2020
Closed
Draft
@oakbani Owais Akbani (oakbani) mentioned this pull request Jul 24, 2020
Merged
@AmnaEjaz Amna Ejaz (AmnaEjaz) mentioned this pull request Jul 30, 2020
Merged
Closed
@oakbani Owais Akbani (oakbani) mentioned this pull request Sep 15, 2020
Merged
This was referenced Jan 21, 2021
Closed
Open
Merged
@graingert Thomas Grainger (graingert) mentioned this pull request Apr 1, 2021
Closed
@ozayr-zaviar Ozayr (ozayr-zaviar) mentioned this pull request Apr 26, 2021
Closed
@Mat001 Matjaz Pirnovar (Mat001) mentioned this pull request May 5, 2021
Closed
@GordonSo Gordon So (GordonSo) mentioned this pull request May 7, 2021
Closed
@The-inside-man Jake Brown (The-inside-man) mentioned this pull request Jul 9, 2021
Closed
@shujat333 shujat333 mentioned this pull request Jul 9, 2021
Closed
@GordonSo Gordon So (GordonSo) mentioned this pull request Sep 9, 2021
Closed
Merged
@ozayr-zaviar Ozayr (ozayr-zaviar) mentioned this pull request Jun 28, 2022
Merged
@Mat001 Matjaz Pirnovar (Mat001) mentioned this pull request Aug 4, 2022
Merged
Closed
@pvcraven Paul V Craven (pvcraven) mentioned this pull request Feb 24, 2025
Merged
@Mat001 Matjaz Pirnovar (Mat001) mentioned this pull request Jun 6, 2025
Closed
@esrakartalOpt esrakartalOpt mentioned this pull request Dec 3, 2025
Closed
This was referenced Apr 13, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@aliabbasrizvi Ali Abbas Rizvi (aliabbasrizvi) aliabbasrizvi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amilstead @coveralls @aliabbasrizvi