Repository navigation
build: Fix package installation for Python 3.4 and pypy - #298
Merged
Merged
Conversation
Owais Akbani (oakbani)
changed the title
Owais Akbani (oakbani)
requested review from
Ali Abbas Rizvi (aliabbasrizvi) and
Mirza Sohail Hussain (msohailhussain)
September 16, 2020 06:48
Owais Akbani (oakbani)
marked this pull request as ready for review
September 16, 2020 06:56
Mirza Sohail Hussain (msohailhussain)
approved these changes
Sep 16, 2020
Mirza Sohail Hussain (msohailhussain)
left a comment
Mirza Sohail Hussain (msohailhussain)
left a comment
Contributor
There was a problem hiding this comment.
lgtm
Ali Abbas Rizvi (aliabbasrizvi)
approved these changes
Sep 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jsonschema 3.2.0 has a dependency to pyrsistent>=0.14.0. When PIP tries to install the latest pyrsistent version, it requires Python > 3.5. Therefore, in this PR we explicitly define the version for pyrsistent package.
Test plan
All checks continue to pass.