Skip to content

ci(benchmarking): Added benchmarking stage - #187

Merged
Mike Ng (mikeproeng37) merged 9 commits into
masterfrom
sohail/updatedscripttest
Jul 23, 2019
Merged

Mike Ng (mikeproeng37) merged 9 commits into
masterfrom
sohail/updatedscripttest

Conversation

@msohailhussain

@msohailhussain Mirza Sohail Hussain (msohailhussain) commented Jul 5, 2019 •

Copy link
Copy Markdown
Contributor

No description provided.

@coveralls

Coveralls (coveralls) commented Jul 5, 2019 •

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 99.711% when pulling f97f3d8 on sohail/updatedscripttest into 7973aa8 on master.

Comment thread .travis.yml Outdated
stage: 'Benchmarking Tests'
env: SDK=python REPO_SLUG=Benchmarking
script:
- "$HOME/travisci-tools/trigger-script-with-status-update.sh yasir/bench-exp-support"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the yasir/bench-exp-support is for testing right

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the custom branch and merge in now right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, about to remove.

Comment thread .travis.yml Outdated
stages:
- 'Linting'
- 'Integration tests'
- 'Integration Tests'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

travis gui will lowercase this for you even though you specify upppercase... it's annoying :(

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah realized, will change it.

@mikeproeng37 Mike Ng (mikeproeng37) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37
Mike Ng (mikeproeng37) merged commit 968a54e into master Jul 23, 2019
@oakbani
Owais Akbani (oakbani) deleted the sohail/updatedscripttest branch September 24, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants