Repository navigation
ci: Run source clear before linting and tests. - #292
Merged
Ali Abbas Rizvi (aliabbasrizvi) merged 4 commits intoJul 29, 2020
Merged
Conversation
Owais Akbani (oakbani)
requested a review
from Mirza Sohail Hussain (msohailhussain)
July 24, 2020 14:25
Owais Akbani (oakbani)
changed the title
Mirza Sohail Hussain (msohailhussain)
approved these changes
Jul 28, 2020
Mirza Sohail Hussain (msohailhussain)
left a comment
Mirza Sohail Hussain (msohailhussain)
left a comment
Contributor
There was a problem hiding this comment.
lgtm
Mirza Sohail Hussain (msohailhussain)
marked this pull request as ready for review
July 28, 2020 21:08
Mirza Sohail Hussain (msohailhussain)
requested a review
from a team
as a code owner
July 28, 2020 21:08
Ali Abbas Rizvi (aliabbasrizvi)
approved these changes
Jul 29, 2020
Ali Abbas Rizvi (aliabbasrizvi)
deleted the
oakbani/run-srcclr-before-tests
branch
July 29, 2020 18:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stages run sequentially on Travis. If a stage fails, all the following stages are not executed. We execute source clear only on cron, and if due to any reason unit or integration tests fail, the source clear is not executed. Hence, moving source clear stage before tests.
Test plan
All unit tests must be passed.
FSC must be passed.