Skip to content

refac(ci): (adding python 3.7 support fix) use xenial - #159

Closed
JC (juancarlostong) wants to merge 1 commit into
oakbani/python-3.7-supportfrom
jctong/python-3.7-support
Closed

refac(ci): (adding python 3.7 support fix) use xenial#159
JC (juancarlostong) wants to merge 1 commit into
oakbani/python-3.7-supportfrom
jctong/python-3.7-support

Conversation

@juancarlostong

@juancarlostong JC (juancarlostong) commented Jan 7, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Adding python3.7 support. Ubuntu Trusty does not support this version so we have to use Xenial instead.

Note

@juancarlostong JC (juancarlostong) added the wip Work in progress label Jan 7, 2019
@coveralls

Coveralls (coveralls) commented Jan 7, 2019

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 99.695% when pulling 6776691 on jctong/python-3.7-support into bbb8cc2 on oakbani/python-3.7-support.

2 similar comments
@coveralls

Coveralls (coveralls) commented Jan 7, 2019

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 99.695% when pulling 6776691 on jctong/python-3.7-support into bbb8cc2 on oakbani/python-3.7-support.

@coveralls

Coveralls (coveralls) commented Jan 7, 2019

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 99.695% when pulling 6776691 on jctong/python-3.7-support into bbb8cc2 on oakbani/python-3.7-support.

@coveralls

Coveralls (coveralls) commented Jan 7, 2019 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 99.695% when pulling 597ad97 on jctong/python-3.7-support into bbb8cc2 on oakbani/python-3.7-support.

@juancarlostong
JC (juancarlostong) force-pushed the jctong/python-3.7-support branch 3 times, most recently from 7b6d627 to b0f5aa1 Compare January 7, 2019 22:27
@juancarlostong
JC (juancarlostong) force-pushed the jctong/python-3.7-support branch from b0f5aa1 to 597ad97 Compare January 7, 2019 22:39
@juancarlostong JC (juancarlostong) changed the title use xenial refac(ci): (adding python 3.7 support fix) use xenial Jan 7, 2019
@juancarlostong JC (juancarlostong) removed the wip Work in progress label Jan 7, 2019
@juancarlostong JC (juancarlostong) mentioned this pull request Jan 7, 2019
Merged
@aliabbasrizvi

Ali Abbas Rizvi (aliabbasrizvi) commented Jan 8, 2019

Copy link
Copy Markdown
Contributor

Can you combine the changes here with #160?

@msohailhussain

Mirza Sohail Hussain (msohailhussain) commented Jan 8, 2019

Copy link
Copy Markdown
Contributor

Ali Abbas Rizvi (@aliabbasrizvi) Any one PR can be merged #159 or #160, I liked the approach in #160 to use xenial only for python 3.7. We may discard this one.

@aliabbasrizvi

Ali Abbas Rizvi (aliabbasrizvi) commented Jan 8, 2019

Copy link
Copy Markdown
Contributor

I prefer #160 as well. We can close this out.

aliabbasrizvi
Ali Abbas Rizvi (aliabbasrizvi) suggested changes Jan 8, 2019
View reviewed changes

@aliabbasrizvi Ali Abbas Rizvi (aliabbasrizvi) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting to revise so that you may close this.

@aliabbasrizvi
Ali Abbas Rizvi (aliabbasrizvi) deleted the jctong/python-3.7-support branch January 9, 2019 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msohailhussain Mirza Sohail Hussain (msohailhussain) Awaiting requested review from msohailhussain
@mikeproeng37 Mike Ng (mikeproeng37) Awaiting requested review from mikeproeng37
1 more reviewer
@aliabbasrizvi Ali Abbas Rizvi (aliabbasrizvi) aliabbasrizvi requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@juancarlostong @coveralls @aliabbasrizvi @msohailhussain