Repository navigation
tests: Fix intemittent multithreaded unit test failure - #210
Merged
Ali Abbas Rizvi (aliabbasrizvi) merged 7 commits intoSep 20, 2019
Merged
Conversation
1 similar comment
Contributor
Author
|
Looks like the issue with pypy/pypy3 is something else. The background thread is running as I can see the log but the mocked object 'fetch_datafile' is not being told that it has been called. |
This reverts commit 5a39141.
Owais Akbani (oakbani)
requested a review
from Mirza Sohail Hussain (msohailhussain)
September 18, 2019 07:47
Mirza Sohail Hussain (msohailhussain)
requested review from
Ali Abbas Rizvi (aliabbasrizvi)
and removed request for
Ali Abbas Rizvi (aliabbasrizvi)
September 18, 2019 17:53
Mirza Sohail Hussain (msohailhussain)
marked this pull request as ready for review
September 19, 2019 22:59
Mirza Sohail Hussain (msohailhussain)
requested a review
from a team
as a code owner
September 19, 2019 22:59
Ali Abbas Rizvi (aliabbasrizvi)
approved these changes
Sep 20, 2019
Ali Abbas Rizvi (aliabbasrizvi)
deleted the
oakbani/fix-unit-test-on-pypy
branch
September 20, 2019 05:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Polling Manager unit test intermittently fails on some Python versions.
See here: https://travis-ci.org/optimizely/python-sdk/jobs/585691111
Trying multiple approaches of using a short polling interval, using a blocking queue with a mocked side_effect, and putting a time sleep before assertion reveals that this is some issue with mocked object on pypy and pypy3 that it does not know even if it has been called many times.
We can get rid of this assertion since we are already asserting is_running flag to ensure that the thread is running
Test plan
Should pass existing unit tests.
Issues