Repository navigation
ci: Install a compatible version of cryptography for pypy and pypy3 in travis config - #320
Merged
Merged
Conversation
Owais Akbani (oakbani)
changed the title
Mirza Sohail Hussain (msohailhussain)
marked this pull request as ready for review
March 5, 2021 18:20
Mirza Sohail Hussain (msohailhussain)
requested a review
from a team
as a code owner
March 5, 2021 18:20
Matjaz Pirnovar (Mat001)
requested changes
Mar 5, 2021
| - stage: 'Test' | ||
| python: "pypy" | ||
| before_install: | ||
| - pip install "cryptography>=1.3.4,<=3.1.1" # installing in before_install doesn't re-install a latest version of the same package in the next stage. |
Contributor
There was a problem hiding this comment.
Can you fix grammatical error: Change "a latest version of the same" to "the latest version of the same".
Add comment to README about installing cryptography when using PyPy
Added additional explanation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unit tests on Python pypy and pypy3 have been failing consistently for quite some time. On detailed investigation, cryptography package is required by the requests[security] module. Although the latest cryptography version does support pypy, it doesn't build for some reason.
Setting cryptography package to a static previous version revealed that Python 3.4 support has been dropped after cryptography 2.8.
Therefore, instead of modifying requirements file, we install the correct working version of cryptography in before_install phase of pyp build.
Test plan
All checks continue to pass.
Issues