Repository navigation
feat(notification-center): Add LogEvent notification - #213
Merged
Ali Abbas Rizvi (aliabbasrizvi) merged 103 commits intoOct 7, 2019
Merged
Conversation
Summary ------- - Introduces an EventProcessor interface. - Introduces a BatchEventProcessor Buffering events within a queue before dispatching is an optimization that should prevent SDK implementations from exhausting resources while increasing throughput. This implementation relies on a BlockingCollection to buffer events received from one-to-many producers. A single consumer thread continuously polls from this queue to build a batch before emitting the batched LogEvent. Test plan --------- - Added unit tests.
# Conflicts: # optimizely/event/entity/conversion_event.py # optimizely/event/entity/decision.py # optimizely/event/entity/event_context.py # optimizely/event/entity/impression_event.py
# Conflicts: # optimizely/event/entity/user_event.py # optimizely/event/entity/visitor.py
# Conflicts: # optimizely/event/event_processor.py
…into mnoman/AddBatchEP
…into mnoman/AddBatchEP
# Conflicts: # optimizely/event/event_processor.py
…/python-sdk into mnoman/log_event_notification
…event_notification
Owais Akbani (oakbani)
requested a review
from Ali Abbas Rizvi (aliabbasrizvi)
October 4, 2019 19:41
Ali Abbas Rizvi (aliabbasrizvi)
approved these changes
Oct 4, 2019
Ali Abbas Rizvi (aliabbasrizvi)
left a comment
Ali Abbas Rizvi (aliabbasrizvi)
left a comment
Contributor
There was a problem hiding this comment.
Looks good.
3 similar comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a replica of #204.
Test plan
Added unit test