Skip to content

[FSSDK-11212] Update code to retry web API calls for fetching datafile and pushing events - #445

Merged
Paul V Craven (pvcraven) merged 14 commits into
masterfrom
pvcraven-FSSDK-11212
Feb 26, 2025
Merged

Paul V Craven (pvcraven) merged 14 commits into
masterfrom
pvcraven-FSSDK-11212

Conversation

@pvcraven

@pvcraven Paul V Craven (pvcraven) commented Feb 24, 2025 •

Copy link
Copy Markdown
Contributor

Summary

  • Retry connections for posting events and pulling datafiles.
    • By default, 3 attempts to get datafile. (Configurable)
    • Twice to send event data. (Non-configurable)
  • Fix for mypy issue, as mypy updated and is no longer happy

Test plan

  • Unit tests
  • Test actual sdk

Issues

@jaeopt Jae Kim (jaeopt) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the wrong value for event retries

Comment thread optimizely/event_dispatcher.py Resolved

@Mat001 Matjaz Pirnovar (Mat001) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaeopt Jae Kim (jaeopt) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvcraven
Paul V Craven (pvcraven) merged commit d098f9a into master Feb 26, 2025
@pvcraven
Paul V Craven (pvcraven) deleted the pvcraven-FSSDK-11212 branch February 26, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants