Repository navigation
fix: allow typed identity in derived maintenance arithmetic - #507
Merged
Merged
Conversation
zzylol
marked this pull request as ready for review
September 30, 2026 15:22
zzylol
force-pushed
the
docs/physical-coverage-handoff
branch
from
September 30, 2026 18:27
bd367a3 to
3d2b95d
Compare
zzylol
force-pushed
the
fix/typed-maintenance-binary
branch
from
September 30, 2026 18:27
a049a3b to
acdea1d
Compare
zzylol
force-pushed
the
docs/physical-coverage-handoff
branch
from
September 30, 2026 20:25
3d2b95d to
2101e97
Compare
zzylol
force-pushed
the
fix/typed-maintenance-binary
branch
2 times, most recently
from
October 1, 2026 22:48
1e210a3 to
8446d62
Compare
zzylol
changed the base branch from
docs/physical-coverage-handoff
to
feat/histogram-quantile
October 1, 2026 22:48
zzylol
force-pushed
the
feat/histogram-quantile
branch
from
October 1, 2026 23:14
50c9d6d to
ae5f517
Compare
zzylol
force-pushed
the
fix/typed-maintenance-binary
branch
from
October 1, 2026 23:22
8446d62 to
75f6b78
Compare
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #505.
Why
Upfront PromQL series typing caused derived quantile candidates over two range sums to fail validation and fall back to exact execution.
What
Accept one non-null UTF-8 opaque series identity column in maintenance arithmetic, while rejecting malformed or duplicate identities and arbitrary string columns.
Before this PR:
quantile(0.9, sum_over_time(m[1m]) + sum_over_time(n[1m]))with typed series identity could not export its maintenance candidate.After this PR: typed maintenance arithmetic passes the same schema contract as its physical implementation.
Validation
The focused identity regression fails before the fix and passes afterward; negative cases cover nullable, wrong-type, duplicate and arbitrary string fields. The existing two-source exporter test now uses upfront series typing. Full workspace formatting, Clippy with warnings denied, and all workspace tests pass. Backend immutable complete-group and two-source revision process regressions also pass.
Base is frozen at the previously validated integration tip so integration updates leave this review open.
🤖 Generated with Claude Code