Repository navigation
Conversation
zzylol
force-pushed
the
feat/handoff-physical-coverage
branch
from
September 30, 2026 18:27
07684a9 to
7856e25
Compare
zzylol
force-pushed
the
feat/handoff-label-coverage
branch
from
September 30, 2026 18:27
a1c94d6 to
c32b85a
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
force-pushed
the
feat/handoff-physical-coverage
branch
from
September 30, 2026 20:25
7856e25 to
f2d8cdd
Compare
zzylol
force-pushed
the
feat/handoff-label-coverage
branch
from
September 30, 2026 20:25
c32b85a to
9ab8b2c
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #500.
Why
Native Planner execution rejected extra labels on aggregate binary results, classic multi-quantile histograms, aggregation over histogram results, and
label_replace.What
Expand logical and physical binary result schemas for contributed labels; render result identities explicitly. Add native anchored-regex label rewriting and classic histogram-quantile branch concatenation with duplicate checks. Resolve nested aggregate sample values through the existing column resolver.
Before this PR
sum by(job)(a) * on(job) group_left(team) infofailed becauseteamwas absent from the left schema;sum(histogram_quantile(...)),histogram_quantiles, andlabel_replacecould not execute natively.After this PR
All these expressions compile, survive plan JSON persistence, and execute through Planner operators. Extra labels and nonmatches are preserved; duplicate output identities and invalid label destinations are rejected.
Validation
Three focused acceptance regressions failed before implementation. All 38 fallback tests pass afterward, including named regex captures, missing sources, empty destinations, grouped
or/group_right, and duplicate quantile labels. Full workspace tests, formatting, and all-target workspace clippy pass.🤖 Generated with Claude Code