Repository navigation
Conversation
zzylol
force-pushed
the
fix/typed-precompute-identity
branch
from
September 30, 2026 18:27
8dd8910 to
9243647
Compare
zzylol
force-pushed
the
feat/handoff-physical-coverage
branch
from
September 30, 2026 18:27
07684a9 to
7856e25
Compare
…values Add query-scoped time scalars, lossless non-finite literal JSON encoding, and compensated SumV2 state with explicit legacy rejection. Correct the stale bool/fill corpus note. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
force-pushed
the
fix/typed-precompute-identity
branch
from
September 30, 2026 20:25
9243647 to
a480a12
Compare
zzylol
force-pushed
the
feat/handoff-physical-coverage
branch
from
September 30, 2026 20:25
7856e25 to
f2d8cdd
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #499.
Why
Planner rejected runtime
time()operands, lost non-finite literals during JSON persistence, and lost small increments in stored exact sums.What
Compile evaluation-time scalar sources, share explicit NaN/Inf literal encoding between logical and physical values, and retain Kahan-Neumaier compensation in the versioned
SumV2exact state. Update coverage documentation and the stale corpus bool/fill note.Before this PR
a + time()failed native compilation;vector(NaN)failed plan JSON decoding; storing[1e16, 1]and merging[-1e16]returned zero.After this PR
The same queries compile and persist correctly, and the merged exact sum is one. Old uncompensated
Sumpayloads are rejected explicitly; deployments must bump their surrounding persisted format.Validation
All three regressions failed before their fixes and passed after. Added direct vector-literal typing and Inf/NaN sum review regressions. Formatting, workspace all-target clippy with warnings denied, and full workspace tests pass.
🤖 Generated with Claude Code