Repository navigation
Conversation
zzylol
force-pushed
the
feat/handoff-physical-coverage
branch
from
September 30, 2026 18:27
07684a9 to
7856e25
Compare
zzylol
force-pushed
the
fix/stored-series-binary
branch
from
September 30, 2026 18:27
a21e656 to
9f8c1dc
Compare
zzylol
changed the base branch from
feat/handoff-physical-coverage
to
feat/handoff-range-bounds
September 30, 2026 18:28
Drop metric names at temporal summary readouts so stored filter comparisons and set operators follow PromQL matching. Keep lowering independent of timing and cover exact sum/count readouts through serialized plans. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
force-pushed
the
feat/handoff-range-bounds
branch
from
September 30, 2026 20:25
9ed2e69 to
7edd134
Compare
zzylol
force-pushed
the
fix/stored-series-binary
branch
from
September 30, 2026 20:25
9f8c1dc to
f914507
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #502.
Why
Stored per-series readouts retained metric names, so Planner rejected filter comparisons and set operators over these values.
What
Normalize the series identity at temporal readouts, including integer count conversion, and enable the existing Binary lowering. Keep the lowering identical across lifecycle timing cuts.
Before this PR
A comparison or set operation between stored temporal readouts could not compile.
After this PR
Stored sum and count readouts match after dropping metric names, producing the expected filtered or combined series. Stored state itself retains its complete identity.
Validation
Regression failed before the fix and passes after, including serialized-plan execution. Updated deployment and compile/cut tests. Workspace fmt, all-target clippy with warnings denied, and full workspace tests passed.
🤖 Generated with Claude Code