Repository navigation
Conversation
zzylol
force-pushed
the
feat/handoff-range-bounds
branch
from
September 30, 2026 18:27
2096e3a to
9ed2e69
Compare
zzylol
force-pushed
the
fix/nonfinite-intent-parameters
branch
from
September 30, 2026 18:27
ee17298 to
e2985bc
Compare
zzylol
changed the base branch from
feat/handoff-range-bounds
to
fix/stored-series-binary
September 30, 2026 18:28
Use the shared float encoding for parameters such as histogram quantiles and prediction horizons; reject old null encodings instead of losing the literal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
force-pushed
the
fix/stored-series-binary
branch
from
September 30, 2026 20:25
9f8c1dc to
f914507
Compare
zzylol
force-pushed
the
fix/nonfinite-intent-parameters
branch
from
September 30, 2026 20:25
e2985bc to
af6a7e6
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #503.
Why
Non-finite scalar literals survived plan JSON, but lowering a literal into an intent parameter still lost it:
histogram_quantile(NaN, x_bucket)encoded its quantile asnull.What
Use the shared explicit NaN/Inf encoding for floating intent parameters, including quantiles and prediction horizons. Correct the corpus serialization caveat.
Before this PR
The logical histogram quantile DAG failed JSON decoding with
invalid type: null, expected f64.After this PR
Logical and compiled DAGs preserve the non-finite parameter and return the intended NaN result. Finite numeric encodings stay unchanged.
Validation
Focused logical-DAG regression failed before the fix and passed after. All 41 fallback tests and all-target workspace clippy pass; formatting checked.
🤖 Generated with Claude Code