Skip to content

Resolve PromQL range anchors from runtime query bounds - #502

Closed
zzylol wants to merge 2 commits into
feat/handoff-label-coveragefrom
feat/handoff-range-bounds
Closed

zzylol wants to merge 2 commits into
feat/handoff-label-coveragefrom
feat/handoff-range-bounds

Conversation

@zzylol

@zzylol zzylol commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on #501.

Why

Planner could not compile PromQL @ start() and @ end() because the outer range query bounds belong to the deployment.

What

Retain those anchors in compiled series windows and subquery grids. Add RunContext::with_query_range so deployments bind outer query bounds per run. Missing or invalid bounds fail before input consumption.

Before this PR

a @ start() and max_over_time(a[2m:1m] @ end()) failed native compilation.

After this PR

The same reusable plans execute against explicitly supplied outer bounds, including offsets and inner selector anchors, while result timestamps remain the current query evaluation time. Instant-query callers supply equal start/end bounds.

Validation

Compile regression failed before implementation. All 40 fallback tests pass after; runtime tests cover both anchors, offsets, range functions, subquery grids, inner anchors, output timestamps, and missing-bound rejection. Formatting and workspace all-target clippy pass; full workspace test sweep plus corrected old-rejection target pass.

🤖 Generated with Claude Code

zzylol and others added 2 commits September 30, 2026 19:13
RunContext query bounds let reusable programs execute @ start() and @ end() on selectors and subquery grids without embedding deployment timestamps. Missing bounds fail before inputs are consumed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@zzylol
zzylol force-pushed the feat/handoff-label-coverage branch from c32b85a to 9ab8b2c Compare September 30, 2026 20:25
@zzylol
zzylol force-pushed the feat/handoff-range-bounds branch from 9ed2e69 to 7edd134 Compare September 30, 2026 20:25
@zzylol

zzylol commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Included in the squash merge of #507 into main (79f3587).

@zzylol zzylol closed this Oct 1, 2026
@milindsrivastava1997
milindsrivastava1997 deleted the feat/handoff-range-bounds branch November 4, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant