Repository navigation
Conversation
zzylol
force-pushed
the
feat/cms-scaled-total
branch
from
September 30, 2026 18:27
adbbd40 to
cc766fe
Compare
zzylol
force-pushed
the
fix/typed-precompute-identity
branch
from
September 30, 2026 18:27
8dd8910 to
9243647
Compare
The physical population row already retains the complete series identity. Validate and admit its logical metadata column instead of rejecting correctly typed derived summaries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
force-pushed
the
feat/cms-scaled-total
branch
from
September 30, 2026 20:24
cc766fe to
112148d
Compare
zzylol
force-pushed
the
fix/typed-precompute-identity
branch
from
September 30, 2026 20:25
9243647 to
a480a12
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #498.
Supersedes #497, which carried the same change against
integration/planner-for-backend; GitHub marked #497 merged when its head was incorporated into that branch, but it never reached main. Review this PR instead; #497 stays closed.Why
Typing PromQL series identity before planning caused derived precompute finalization to reject its logical metadata column.
What
Allow exactly one non-null Utf8 series-identity column in precompute value schemas. The physical population row already retains that identity.
Before this PR
A typed derived summary such as
quantile(0.9, sum_over_time(m[1m]))could fail compilation at exact finalization.After this PR
Finalization and subsequent binary/summary computation preserve identities through the existing
$populationmetadata.Validation
Recovery/derived-summary regression failed before the fix and passes after. All five precompute population tests pass, including malformed, nullable, and duplicate identity rejection.
🤖 Generated with Claude Code