Repository navigation
Spec: the Ticket run as a Built-in process file - #1475
Merged
Merged
Conversation
Retain Resume context across Custom process Steps
Preserve Process inspection and Resume documentation together, and regenerate the user manual HTML.
Add Built-in process catalog and process show
Add the security-review catalogue Step
Add an implement catalogue Step for Custom processes
Route Issue URL and Pickup Ticket runs through ticket-run.toml
Run every Ticket starter through the built-in process
JacobStephens2
marked this pull request as ready for review
October 28, 2026 02:16
Keep the shared Resume definition and reconcile compact CLI help, preserving both Process inspection and other-account commands. Validation: cargo clippy --all-targets -- -D warnings; cargo fmt --check; NEXTEST_TEST_THREADS=3 scripts/affected-tests main (51 site tests and 3,333 Rust tests passed, 74 skipped; 2,200.23 seconds including compilation).
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every Ticket starter now runs the same compiled-in, validated
processes/ticket-run.toml. Dispatch still chooses Spec or Ticket, makes any Claim before the worktree, and passes child choices and Limits through.Custom processes gain the same
implementandsecurity-reviewcatalogue Steps. An unreproduced bug ends successfully, skips later Steps, hands the issue back withneeds-info, ends the Claim and cleans up. Session Steps retain one Resume and carry killed-work context into later failures without spending the Repair cap. Ticket names, session kinds, stages, traces, notifications, interruption and Failed ticket run recovery stay intact.process listmarks built-ins;process show <name>prints built-in or Custom files exactly. Savingticket-rununder a new name produces a runnable Custom process; built-in names remain reserved. Packaging, the guide, glossary and hand-written site pages cover the new ownership and commands.The whole-Spec review also consolidates killed-work retention and the clean Security review test fixture, and removes the redundant Pickup dispatch variant.
Closes #1456
Evidence
After: the compiled Ticket file passes
process check, and its printed copy runs through the CLI as a Custom process. Existing regression tests cover Ticket starters, identity, bug diagnosis, Continuation, Security holds and fallback, Claims, Recovery and interruption..thirdshift-review-j5JP54/.cargo test --test processpassed 150 tests, with 1 fixture entry point ignored. This included compiled-file inspection/copying, bug diagnosis, Continuation, Security fallback/holds and Resume regressions.scripts/affected-tests mainpassed all 51 site tests, then stopped after 554 Rust passes onstop_and_resume_preserve_finished_trials_and_refuse_a_changed_bar(tests/experiments.rs:1365, retained repository directory assertion). The Experiments test and implementation are unchanged in this Spec. The exactcargo test --test experiments stop_and_resume_preserve_finished_trials_and_refuse_a_changed_bar -- --exact --nocapturererun passed, as did all 5 iterations ofcargo nextest run --test experiments -E 'test(=stop_and_resume_preserve_finished_trials_and_refuse_a_changed_bar)' --stress-count 5. This shows intermittent behavior; the initial failure is retained in the Session's validation log.NEXTEST_TEST_THREADS=8 /usr/bin/time -p cargo nextest run --no-fail-fast --retries 0passed all 3,306 tests, with 74 skipped and zero retries. Wall time: 1,399.82 seconds (23m 20s), including the cached build check; no recompilation.cargo fmt --checkalso passed.cargo test --locked --test pickup_model -- --nocapturepassed 4 tests, with 1 ignored. The dispatch cleanup preserves request ordering and requires no model edit. This verifies the bounded claimed-dispatch property and retains the known pre-Claim counterexample; it does not prove the broader literal dispatch property.Testing seams: the existing CLI with real Git, fake
ghand fake Harnesses (Scenario), plus the existing Delivery and Ticket dispatch/sequence seams. No new seam or implementation-only assertion was added for the maintenance refactors.The Day shift's pre-merge live checks from a Spec-branch build remain pending: a fresh Ticket run, Continuation, reproduced and unreproduced bugs, and Pickup and Spec runs that start Tickets.
Unaddressed findings
Standards
None. All three raised findings were addressed.
Spec
None. No findings were raised.
Security
None. No unaddressed introduced findings.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
The change can be reverted; it introduces no persistent format migration. The Spec PR remains draft for thirdshift to mark ready after its remaining review. The Day shift runs the live checks before merge; this Spec must never Self-merge.
Blast Radius: Workflow
Every Ticket starter uses the new compiled sequence. A sequencing regression could affect scheduled and child runs, so the existing Delivery, Security, Claim and recovery gates remain shared and the live checks are required before merge.
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh
Tickets
process show#1459 landed with Add Built-in process catalog and process show #1470security-reviewcatalogue Step #1461 landed with Add the security-review catalogue Step #1487implementcatalogue Step #1462 landed with Add an implement catalogue Step for Custom processes #1491ticket-runfile #1463 landed with Route Issue URL and Pickup Ticket runs through ticket-run.toml #1502ticket-runfile, and the old sequencing goes #1464 landed with Run every Ticket starter through the built-in process #1506