Repository navigation
Retain Resume context across Custom process Steps - #1466
Merged
Merged
Conversation
This was referenced Oct 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retain killed background work across Custom process session Steps so a later failure names the unfinished Resume's work first. Reuse the Ticket run's Resume policy and failure wording.
Closes #1460
Evidence
cargo test --test process killed_work_is_named_before_a_later_process_step_failure -- --exactfailed: the retained Process cause was onlyexit status 9.After: the same test passes with and without an issue. Parallel killed-work ordering and carry-on success tests also pass.
repair_cap = 1completes one Resume, then one real CI Repair and Self-merge (a_process_resume_leaves_the_full_repair_cap_for_delivery).cargo test --test process --test background_work: Process 123 passed; unchanged Ticket background-work tests 4 passed; one fixture entry ignored in each file.cargo check --bin thirdshift: passed.7cd06b92: 3,276 passed, 74 skipped (897.295s test execution). Site, Console and release checks are green too./usr/bin/time -p scripts/affected-tests issue-1456: all 51 site checks passed; local Rust execution stopped after 773 passes on the existing OTLP timing assertiona_stalled_receiver_cannot_delay_a_session_by_its_span_count(baseline 6.62s, stalled 10.09s, allowance 2s; 2,502 tests not run). Total 1,652.96s, including compilation and site checks; Rust compilation took 6m 34s.cargo test --test otlp_endpoint a_stalled_receiver_cannot_delay_a_session_by_its_span_count -- --exact. The full-suite result above comes from successful CI on this exact head; the local failures are retained here.Test seam: the
thirdshift process <name>CLI, with real Git and fake external Harness/GitHub commands; observe exit status, progress, retained Command cause, session arguments and Delivery.Review coverage
Independent Standards and Spec reviews against
issue-1456: 0 findings on each axis. Both reviewers read all 10 changed files, including generated HTML. No generated-output exclusions or unread changed files.Merge Danger
Door: two-way
Blast Radius: Processes
Affects failure causes and retained Command records for Custom processes after killed background work.
Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh
Security review outcome
No unaddressed introduced findings.