Skip to content

Retain Resume context across Custom process Steps - #1466

Merged
JacobStephens2 merged 1 commit into
issue-1456from
issue-1460
Oct 27, 2026
Merged

JacobStephens2 merged 1 commit into
issue-1456from
issue-1460

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

Summary

Retain killed background work across Custom process session Steps so a later failure names the unfinished Resume's work first. Reuse the Ticket run's Resume policy and failure wording.

session Step → one Resume → retain killed-work context
following Steps
  succeed → normal Process result
  fail    → killed-work context; failing Step's cause

Closes #1460

Evidence

  • Before: cargo test --test process killed_work_is_named_before_a_later_process_step_failure -- --exact failed: the retained Process cause was only exit status 9.
    After: the same test passes with and without an issue. Parallel killed-work ordering and carry-on success tests also pass.
  • A Process with repair_cap = 1 completes one Resume, then one real CI Repair and Self-merge (a_process_resume_leaves_the_full_repair_cap_for_delivery).
  • cargo test --test process --test background_work: Process 123 passed; unchanged Ticket background-work tests 4 passed; one fixture entry ignored in each file.
  • cargo check --bin thirdshift: passed.
  • Full Rust CI on 7cd06b92: 3,276 passed, 74 skipped (897.295s test execution). Site, Console and release checks are green too.
  • /usr/bin/time -p scripts/affected-tests issue-1456: all 51 site checks passed; local Rust execution stopped after 773 passes on the existing OTLP timing assertion a_stalled_receiver_cannot_delay_a_session_by_its_span_count (baseline 6.62s, stalled 10.09s, allowance 2s; 2,502 tests not run). Total 1,652.96s, including compilation and site checks; Rust compilation took 6m 34s.
  • The OTLP test also failed its first isolated rerun (baseline 4.73s, stalled 9.03s), then passed both at the fixed-point base and on the PR head using cargo test --test otlp_endpoint a_stalled_receiver_cannot_delay_a_session_by_its_span_count -- --exact. The full-suite result above comes from successful CI on this exact head; the local failures are retained here.

Test seam: the thirdshift process <name> CLI, with real Git and fake external Harness/GitHub commands; observe exit status, progress, retained Command cause, session arguments and Delivery.

Review coverage

Independent Standards and Spec reviews against issue-1456: 0 findings on each axis. Both reviewers read all 10 changed files, including generated HTML. No generated-output exclusions or unread changed files.

Merge Danger

Door: two-way

Blast Radius: Processes

Affects failure causes and retained Command records for Custom processes after killed background work.

Unaddressed findings

Standards

None.

Spec

None.

Security

None.

Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh

Security review outcome

No unaddressed introduced findings.

@JacobStephens2
JacobStephens2 merged commit 3da4d33 into issue-1456 Oct 27, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1460 branch October 27, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant