Skip to content

Add Built-in process catalog and process show - #1470

Merged
JacobStephens2 merged 4 commits into
issue-1456from
issue-1459
Oct 27, 2026
Merged

JacobStephens2 merged 4 commits into
issue-1456from
issue-1459

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

Summary

processes/*.toml → compiled Process catalog
                    ├─ process list: Built-in + Custom processes
                    └─ process show <name>: exact file contents

Adds the Built-in process folder and embedding mechanism, preserves reserved names, and documents inspection and copying. No real Built-in process ships in this ticket; ticket-run follows in #1463.

Closes #1459

Evidence

  • Before: process_show_prints_the_custom_file_exactly failed because process show was unrecognized; compiled-catalog, explicit-list and package-content regressions also failed before their changes.
    After: Those regressions pass, covering exact newlines/CRLF/empty files, unknown names, compiled Built-in inspection/listing, and reserved-name collisions.
  • cargo test --test process --test packaging: 128 passed, 1 ignored. cargo test --bin thirdshift processes::catalog::tests: 2 passed. cargo check --bin thirdshift: passed.
  • The existing 320px page-fit tests failed with the longer command example and now pass with JavaScript both on and off.
  • The full run exposed the existing 68-line help limit; combining two explanatory lines preserves every command and restores the limit. cargo test --test command_surface: 20 passed, 1 ignored.
  • NEXTEST_TEST_THREADS=8 /usr/bin/time -p scripts/affected-tests issue-1456: 51 site checks passed; the Rust run stopped early on a Console HTTP timeout after 273 passes (437.35s wall, including compilation).
  • cargo test --test console accounts::password_codes::code_expiry_is_enforced_over_http_with_a_delivered_code -- --exact: passed alone in 5.76s.
  • Full Rust validation on exact commit 14e912a8: CI passed, 3,278 passed, 74 skipped; 842.776s execution plus 59.07s compilation. Formatting, clippy, site, Console and release checks also passed. The successful CI result is reused instead of repeating the full suite on the same head.

Testing seams

  • CLI: thirdshift process show, list, and reserved names.
  • Process catalog: compiled directory and Custom process files.
  • Cargo package contents: embedded Process sources ship with the crate.

Review coverage

Independent thirdshift-code-review against issue-1456: Standards 0, Spec 0. Both reviewers read all 15 changed files through c1f9e60e. Unread final hunk: the help-text line consolidation in src/main.rs at 14e912a8 was added after their single permitted follow-up; the existing compact-help regression passes. Generated-output exclusions: none.

Unaddressed findings

Standards

None.

Spec

None.

Security

None.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Code and documentation can be reverted; there is no stored-data migration.

Blast Radius: Processes

Changes Process discovery and inspection. show becomes a reserved command name.

Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit f21175a into issue-1456 Oct 27, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1459 branch October 27, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant