Skip to content

Route Issue URL and Pickup Ticket runs through ticket-run.toml - #1502

Merged
JacobStephens2 merged 3 commits into
issue-1456from
issue-1463
Oct 28, 2026
Merged

JacobStephens2 merged 3 commits into
issue-1456from
issue-1463

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

Summary

Ticket runs from Issue URLs and Pickup runs execute the compiled ticket-run Process, keeping their existing Command identity, sessions, progress lines and Delivery lifecycle.

Issue URL / Pickup
  issue with sub-issues → Spec run
  Ticket → Claim → Issue-branch worktree
    ticket-run.toml
      implement → security-review → delivery → self-merge

The file inherits the Command's Harness, Model and Effort. The Security review and Self-merge keep their existing gates. process list, show and check expose it; saving show output under a new name runs a Custom process. Spec, Architect and Security Ticket starters remain on their current path for this Ticket.

Test seams

  • CLI with real Git, fake GitHub and fake Harnesses (Scenario): Process list/show/check, copying a Built-in process, and existing Ticket-run behavior.

Evidence

  • Before: cargo test --test process ticket_run_is_listed_and_shown_as_a_compiled_process failed because the catalogue had no ticket-run; cargo test --test process the_compiled_ticket_run_passes_check_and_its_printed_copy_runs_as_custom failed with reserved name: ticket-run at process check.
    After: Both tests pass, including running the printed copy to a ready pull request.
  • cargo check --all-targets passed.
  • cargo fmt --check passed. The six existing hand-written page layout tests pass at 320px, 390px and 1280px, with and without JavaScript.
  • cargo test --locked --test pickup_model -- --nocapture: 4 passed, 1 known-property assertion ignored. Claimed-dispatch safety passes within the existing model bounds; both no-claim-count and no-empty-lease mutation assertions fail with the expected counterexamples. The documented pre-Claim dispatch counterexample remains reachable. Dispatch, reservation and Claim request ordering is unchanged, so no model change was needed.
  • /usr/bin/time -p scripts/affected-tests ede9f3715dfdaa615eef470fde458baf8b4b63f7 passed: 51 site checks; 3,306 Rust tests passed, 74 skipped. This includes fresh-run, Continuation, bug-run, background-work, Security review, merge-run, Failed-run, Pickup-run, status, Console and progress-line suites. Total wall time was 2,517.38s, including site checks and 3m 50s of Rust compilation; cargo nextest run execution took 2,118.078s on this four-CPU host.

Merge Danger

Door: two-way

Revert this routing change to restore the previous sequence.

Blast Radius: Execution

Issue URL and Pickup Ticket execution changes. The existing checked session scope, failure preservation, Repair loop and guarded Self-merge remain shared.

Unaddressed findings

Standards

None. The Standards reviewer raised 0 findings.

Spec

None. The Spec reviewer raised 0 findings.

Security

None. The Security reviewer raised 0 findings.

Security review outcome

No unaddressed introduced findings.

Review coverage

Both independent reviewers read all 17 changed files against issue-1456, pinned at ede9f3715dfdaa615eef470fde458baf8b4b63f7. No changed files remain unread under either axis. No generated-output exclusions: both reviewers inspected the generated documentation diff directly. Reports and {"standards":0,"spec":0} summary are saved in .thirdshift-review-nn2n4S/ beside the Session evidence.

Closes #1463

Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit 2a16d71 into issue-1456 Oct 28, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1463 branch October 28, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant