Repository navigation
Route Issue URL and Pickup Ticket runs through ticket-run.toml - #1502
Merged
Merged
Conversation
This was referenced Oct 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ticket runs from Issue URLs and Pickup runs execute the compiled
ticket-runProcess, keeping their existing Command identity, sessions, progress lines and Delivery lifecycle.The file inherits the Command's Harness, Model and Effort. The Security review and Self-merge keep their existing gates.
process list,showandcheckexpose it; savingshowoutput under a new name runs a Custom process. Spec, Architect and Security Ticket starters remain on their current path for this Ticket.Test seams
Scenario): Process list/show/check, copying a Built-in process, and existing Ticket-run behavior.Evidence
cargo test --test process ticket_run_is_listed_and_shown_as_a_compiled_processfailed because the catalogue had noticket-run;cargo test --test process the_compiled_ticket_run_passes_check_and_its_printed_copy_runs_as_customfailed withreserved name: ticket-runatprocess check.After: Both tests pass, including running the printed copy to a ready pull request.
cargo check --all-targetspassed.cargo fmt --checkpassed. The six existing hand-written page layout tests pass at 320px, 390px and 1280px, with and without JavaScript.cargo test --locked --test pickup_model -- --nocapture: 4 passed, 1 known-property assertion ignored. Claimed-dispatch safety passes within the existing model bounds; bothno-claim-countandno-empty-leasemutation assertions fail with the expected counterexamples. The documented pre-Claim dispatch counterexample remains reachable. Dispatch, reservation and Claim request ordering is unchanged, so no model change was needed./usr/bin/time -p scripts/affected-tests ede9f3715dfdaa615eef470fde458baf8b4b63f7passed: 51 site checks; 3,306 Rust tests passed, 74 skipped. This includes fresh-run, Continuation, bug-run, background-work, Security review, merge-run, Failed-run, Pickup-run, status, Console and progress-line suites. Total wall time was 2,517.38s, including site checks and 3m 50s of Rust compilation;cargo nextest runexecution took 2,118.078s on this four-CPU host.Merge Danger
Door: two-way
Revert this routing change to restore the previous sequence.
Blast Radius: Execution
Issue URL and Pickup Ticket execution changes. The existing checked session scope, failure preservation, Repair loop and guarded Self-merge remain shared.
Unaddressed findings
Standards
None. The Standards reviewer raised 0 findings.
Spec
None. The Spec reviewer raised 0 findings.
Security
None. The Security reviewer raised 0 findings.
Security review outcome
No unaddressed introduced findings.
Review coverage
Both independent reviewers read all 17 changed files against
issue-1456, pinned atede9f3715dfdaa615eef470fde458baf8b4b63f7. No changed files remain unread under either axis. No generated-output exclusions: both reviewers inspected the generated documentation diff directly. Reports and{"standards":0,"spec":0}summary are saved in.thirdshift-review-nn2n4S/beside the Session evidence.Closes #1463
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh