Skip to content

Run every Ticket starter through the built-in process - #1506

Merged
JacobStephens2 merged 2 commits into
issue-1456from
issue-1464
Oct 28, 2026
Merged

JacobStephens2 merged 2 commits into
issue-1456from
issue-1464

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

Summary

 Ticket dispatch (Spec selection, Claim, worktree, Child asks and Limits)
-  Issue URL / Pickup → ticket-run file; other starters → Rust sequence
+  every Ticket starter → ticket-run file
     implement → security-review → delivery → self-merge
 Spec PR → Spec review → optional Security review → Delivery

Closes #1464

Retains all 17 existing Delivery tests and 54 assertions: nine Ticket sequence tests now exercise the compiled Process; eight Spec/shared recovery tests stay with Delivery. Updates the glossary, Process documentation and site pages.

Evidence

  • Before: Spec, Architect and Security starters could select the Rust Ticket sequence.
    After: dispatch always invokes the compiled ticket-run; the Rust sequence accepts only a Spec review.
  • cargo check passed. Focused tests passed: 9 compiled Ticket Process tests, 8 Delivery tests and 64 dispatch/child/Spec tests.
  • /usr/bin/time -p scripts/affected-tests origin/issue-1456 passed: 51 site tests and all 3,306 Rust tests across 77 binaries (74 skipped). Rust execution took 1,809.162s; the complete selection took 2,019.74s including compilation and site checks. Rust test compilation took 1m 52s.
  • CI passed for final commit df25c623, including Rust, site and Console checks.
  • Seams under test: Run dispatch; compiled Ticket Process execution through the existing Delivery I/O adapter; Spec PR Delivery; public CLI integration suites.

Unaddressed findings

  • Standards: none. The sole finding, obsolete Spec opening support in the Ticket helper, was fixed in df25c623 and confirmed resolved by its reviewer.
  • Spec: none; zero findings.
  • Security: none; zero introduced findings.

Security review outcome

No unaddressed introduced findings.

Review coverage

Both independent reviewers read all 15 changed files, including generated site/docs/index.html, and checked the cleanup commit. No changed files were left unread; no generated output was excluded. Reviews use issue-1456 pinned at 2a16d71a3f9351fc1cb8dbb4dc9b92b0b7b57ea2. Reports and final files-read lists are retained in .thirdshift-review-xmrxgg/{standards,spec}.md; summary.json records {"standards":1,"spec":0}, counting the fixed Standards finding.

Merge Danger

Door: two-way

Blast Radius: dispatch

Changes the execution path for child and dispatched Ticket runs while retaining their settings and lifecycle. Leave the parent Spec PR ready for the Day shift's live checks; do not Self-merge it.

Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit 166379e into issue-1456 Oct 28, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1464 branch October 28, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant