Repository navigation
Add an implement catalogue Step for Custom processes - #1491
Merged
Merged
Conversation
This was referenced Oct 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Custom processes can run the Ticket run's shared implementation and bug diagnosis:
implementaccepts its own Harness, Model and Effort, uses the common Resume rule, and is refused outside an Issue-branch worktree. Ticket run behavior stays covered by the existing integration suites. The manual and hand-written site pages describe the Step.Closes #1462
Evidence
Test seam: the CLI with real Git, fake
gh, and fake Harnesses (Scenario).cargo test --test process implement::implement_then_delivery_leaves_a_ready_pull_requestfailed becauseimplementwas an unknown catalogue value. The unreproduced-bug test demonstrated unwanted PR delivery; the repeated-implementation test demonstrated an overwritten Session trace.After: new
implementCLI coverage includes fresh runs, Continuation with and without an open PR, merge-base diagnosis, successful early ending, refusal, invalid handoffs, Step settings, Resume and separate traces. Reconciliation addsimplement→security-review→deliveryand verifies an unreproduced bug skips Security review too.security-reviewcatalogue Step #1461: 305 compatibility tests passed across the Process, fresh-run, Continuation, bug-run, Base fix, Security review, merge-run and Failed-run suites; 8 fixture entry points ignored. After the Standards fix, all 11 implementation tests and all 14 Ticket-run bug tests passed again./usr/bin/time -p scripts/affected-tests issue-1456: 51 site tests and 3,291 Rust tests passed; 74 helper/fixture tests skipped. Wall time 2,562.08s, including compilation. The Base branch advanced during this run and was reconciled before publication.cargo fmt --check,cargo clippy --all-targets -- -D warnings, andgit diff --checkpass.608ab895: 3,304 passed, 74 skipped; 861.309s test execution plus 53.94s compilation. Formatting, clippy, site, Console and release-build checks also passed. This successful final-head result is reused rather than repeating the full local suite on the same head.Review fixed point:
issue-1456ate518cb7267bf7780a6e933e9f15d08628e46a4a3. Fresh independent reviews after reconciliation: Standards raised 1 finding, addressed; Spec raised 0. Both reviewers read all 27 changed files, including the catalogue, Resume and Security review prerequisites in this fixed-point diff. Generated-output exclusions: none. Unread changed files: none. Reports and final files-read lists are retained in.thirdshift-review-KyGiid/{standards.md,spec.md,summary.json}in the Session worktree.Unaddressed findings
Standards
None. S1 was addressed by passing label facts into the shared implementation module and restoring Delivery's scripted handoff adapter.
Spec
None; no findings were raised.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Reverting restores the previous catalogue and implementation routing; no persistent format migration.
Blast Radius: Processes
Custom process execution and the shared Ticket run implementation/diagnosis path.
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh