Skip to content

Add an implement catalogue Step for Custom processes - #1491

Merged
JacobStephens2 merged 5 commits into
issue-1456from
issue-1462
Oct 27, 2026
Merged

JacobStephens2 merged 5 commits into
issue-1456from
issue-1462

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

Summary

Custom processes can run the Ticket run's shared implementation and bug diagnosis:

Issue branch (fresh or Continuation)
  implement → delivery → ready-for-review PR
    bug not reproduced → needs-info, end Claim, clean up, skip later Steps

implement accepts its own Harness, Model and Effort, uses the common Resume rule, and is refused outside an Issue-branch worktree. Ticket run behavior stays covered by the existing integration suites. The manual and hand-written site pages describe the Step.

Closes #1462

Evidence

Test seam: the CLI with real Git, fake gh, and fake Harnesses (Scenario).

  • Before: cargo test --test process implement::implement_then_delivery_leaves_a_ready_pull_request failed because implement was an unknown catalogue value. The unreproduced-bug test demonstrated unwanted PR delivery; the repeated-implementation test demonstrated an overwritten Session trace.
    After: new implement CLI coverage includes fresh runs, Continuation with and without an open PR, merge-base diagnosis, successful early ending, refusal, invalid handoffs, Step settings, Resume and separate traces. Reconciliation adds implement → security-review → delivery and verifies an unreproduced bug skips Security review too.
  • After reconciling A security-review catalogue Step #1461: 305 compatibility tests passed across the Process, fresh-run, Continuation, bug-run, Base fix, Security review, merge-run and Failed-run suites; 8 fixture entry points ignored. After the Standards fix, all 11 implementation tests and all 14 Ticket-run bug tests passed again.
  • /usr/bin/time -p scripts/affected-tests issue-1456: 51 site tests and 3,291 Rust tests passed; 74 helper/fixture tests skipped. Wall time 2,562.08s, including compilation. The Base branch advanced during this run and was reconciled before publication.
  • cargo fmt --check, cargo clippy --all-targets -- -D warnings, and git diff --check pass.
  • Full Rust CI on exact head 608ab895: 3,304 passed, 74 skipped; 861.309s test execution plus 53.94s compilation. Formatting, clippy, site, Console and release-build checks also passed. This successful final-head result is reused rather than repeating the full local suite on the same head.

Review fixed point: issue-1456 at e518cb7267bf7780a6e933e9f15d08628e46a4a3. Fresh independent reviews after reconciliation: Standards raised 1 finding, addressed; Spec raised 0. Both reviewers read all 27 changed files, including the catalogue, Resume and Security review prerequisites in this fixed-point diff. Generated-output exclusions: none. Unread changed files: none. Reports and final files-read lists are retained in .thirdshift-review-KyGiid/{standards.md,spec.md,summary.json} in the Session worktree.

Unaddressed findings

Standards

None. S1 was addressed by passing label facts into the shared implementation module and restoring Delivery's scripted handoff adapter.

Spec

None; no findings were raised.

Security

None.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Reverting restores the previous catalogue and implementation routing; no persistent format migration.

Blast Radius: Processes

Custom process execution and the shared Ticket run implementation/diagnosis path.

Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit ede9f37 into issue-1456 Oct 27, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1462 branch October 27, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant