Repository navigation
Conversation
macchian
requested review from
jajanusz,
ranj063 and
xiulipan
as code owners
February 17, 2020 10:39
lgirdwood
requested changes
Feb 17, 2020
Member
There was a problem hiding this comment.
This growth in conditional logic defeats the purpose of the include/define directives. Would we do this in a C file? No.
Far better to have a cml-blah-config and bxt-blah_config.m4 and inlude the correct file (with all these macro defs for format etc.)
Member
Contributor
Author
There was a problem hiding this comment.
Thanks @lgirdwood. @fredoh9 , could you guide me how to include the marcor defs by separate m4 file? Or existed same code can share? Thanks.
Member
Contributor
Author
macchian
force-pushed
the
macchian-cml-008-kwd
branch
from
March 13, 2020 09:23
eb3ea34 to
7a84205
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse sof-glk-da7219-kwd by adding sof-cml-da7219-max98357a
topology with KWD pipeline enabling
Signed-of-by: Mac Chiang mac.chiang@intel.com