Repository navigation
Conversation
lgirdwood
requested changes
Jan 23, 2020
plbossart
reviewed
Jan 23, 2020
Member
There was a problem hiding this comment.
maybe a dumb question, but this machine driver is shared with glk_da7219_max98357a, so can't we share the same topology file and use variables to adjust SSP values?
Author
Contributor
There was a problem hiding this comment.
Per request, reuse the glk topology and update new PR #2397 for reviewing.
refer to 0.4 topology file, migrate to 0.7 by adding supports: 1. dmic16k capture 2. 48KHz speaker playback by m/n divider 3. remove warning widgets messages Signed-off-by: Mac Chiang <mac.chiang@intel.com> Signed-off-by: Sachin Kumar <sachin.kumar@intel.com>
Contributor
|
@kumarsac @lgirdwood Is this PR still valid. Do we use that backport branch? |
Author
This PR can be closed as its been taken care in : #2397 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sof-cml-da7219-max98357a topology is merged only in the cml-007-stable-drop branch. And not pushed to master.