Skip to content

sof-cml-da7219-max98357a topology is merged only in the cml-007-stable-drop branch. And not pushed to master. - #2315

Closed
kumarsac wants to merge 1 commit into
thesofproject:masterfrom
kumarsac:master-push-topology
Closed

sof-cml-da7219-max98357a topology is merged only in the cml-007-stable-drop branch. And not pushed to master.#2315
kumarsac wants to merge 1 commit into
thesofproject:masterfrom
kumarsac:master-push-topology

Conversation

@kumarsac

@kumarsac kumarsac commented Jan 23, 2020

Copy link
Copy Markdown
  1. Cherrypicked the topology from cml-007-stable-drop and resolved conflict.
  2. Fix the Macro Syntax change for topology as per the commit 77b6db8 ("topology: enable pcm range and pipeline rate and remove frame count")

lgirdwood
lgirdwood requested changes Jan 23, 2020
View reviewed changes
Comment thread tools/topology/sof-cml-da7219-max98357a.m4 Resolved
@macchian @kumarsac
topology: cml: topology migration support for da7219+max98357a variant
59ae655 
refer to 0.4 topology file, migrate to 0.7 by adding supports:
1. dmic16k capture
2. 48KHz speaker playback by m/n divider
3. remove warning widgets messages

Signed-off-by: macchian <mac.chiang@intel.com>
Signed-off-by: Sachin Kumar <sachin.kumar@intel.com>
@kumarsac
kumarsac force-pushed the master-push-topology branch from d180970 to 59ae655 Compare January 27, 2020 05:53
@kumarsac
kumarsac requested a review from lgirdwood January 27, 2020 05:55
@lgirdwood

lgirdwood commented Jan 27, 2020

Copy link
Copy Markdown
Member

@kumarsac sorry, I confused, what is the difference to #2314 ? They both look like the same topology ?

@kumarsac

kumarsac commented Jan 27, 2020

Copy link
Copy Markdown
Author

@kumarsac sorry, I confused, what is the difference to #2314 ? They both look like the same topology ?

Yes Both are same changes. This one is for master and #2314 for SOF 008 release branch.
As cml-008-patch-backport is SOF 008 release branch for CML chrome i have raised pull request for that branch also.
As we need to share the branch and commit details for FW binary release.

@lgirdwood

lgirdwood commented Jan 27, 2020

Copy link
Copy Markdown
Member

@kumarsac ok, thanks, just the question on reuse with GLK version as the only open.

@kumarsac

kumarsac commented Jan 28, 2020

Copy link
Copy Markdown
Author

@kumarsac ok, thanks, just the question on reuse with GLK version as the only open.

This is a released topology in SOF 007 (05c8e96) which is pushed to google. I preferred the same topology with PCM arg fixes.
@macchian Please provide your inputs on this...

@jajanusz

jajanusz commented Mar 25, 2020

Copy link
Copy Markdown
Contributor

@kumarsac The same problems as with #2314 . Also do we need both of them? I'm not sure if you wanted to just align topo on master or you need it also on backport branch.

@kumarsac

kumarsac commented Mar 25, 2020

Copy link
Copy Markdown
Author

@kumarsac The same problems as with #2314 . Also do we need both of them? I'm not sure if you wanted to just align topo on master or you need it also on backport branch.

This PR can be closed as its been taken care in : #2397

@kumarsac kumarsac closed this Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jajanusz jajanusz Awaiting requested review from jajanusz
@ranj063 ranj063 Awaiting requested review from ranj063
@xiulipan xiulipan Awaiting requested review from xiulipan
@lgirdwood lgirdwood Awaiting requested review from lgirdwood

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kumarsac @lgirdwood @jajanusz @macchian