Skip to content

topology: add cml support with da7219 and max98357a - #2497

Merged
lgirdwood merged 1 commit into
thesofproject:masterfrom
macchian:macchian-cml-008-kwd-v2
Apr 16, 2020
Merged

lgirdwood merged 1 commit into
thesofproject:masterfrom
macchian:macchian-cml-008-kwd-v2

Conversation

@macchian

@macchian macchian commented Mar 6, 2020

Copy link
Copy Markdown
Contributor

Reuse sof-glk-da7219-kwd by included cml.m4
for sof-cml-da7219-max98357a topology with KWD pipeline enabling

Signed-of-by: Mac Chiang mac.chiang@intel.com

Comment thread tools/topology/sof-glk-da7219-kwd.m4 Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conditional logic should also be in platform.m4, it looks like the only delat is SSP bclk and fsync

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgirdwood ok, eventually I moved all cml specific into platform.m4.

@macchian
macchian force-pushed the macchian-cml-008-kwd-v2 branch from 652f5c3 to d7f26de Compare March 13, 2020 09:23
Comment thread tools/topology/platform/intel/cml.m4 Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have multiple checks for ABI version ? Sure we just need one check.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out. Yes, one check requires only.

@macchian
macchian force-pushed the macchian-cml-008-kwd-v2 branch from d7f26de to c192034 Compare March 16, 2020 03:35
@macchian
macchian force-pushed the macchian-cml-008-kwd-v2 branch from c192034 to 2823ec1 Compare March 17, 2020 09:26
@macchian

Copy link
Copy Markdown
Contributor Author

@jajanusz, could you help +1 approval or someone else? Thanks.

@lgirdwood

Copy link
Copy Markdown
Member

SOFCI TEST

@lgirdwood

Copy link
Copy Markdown
Member

Jenkins CI is known issues.

@macchian

Copy link
Copy Markdown
Contributor Author

Jenkins CI is known issues.

Thanks @lgirdwood , @jajanusz . I am not authorized to merge this PR. Could you help this? Thanks.

@lgirdwood

Copy link
Copy Markdown
Member

SOFCI TEST

Comment thread tools/topology/platform/intel/bxt.m4 Outdated
@macchian
macchian force-pushed the macchian-cml-008-kwd-v2 branch from 2823ec1 to 1103fbb Compare March 30, 2020 03:56

@lgirdwood lgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I think that looks right - you have DMIC, SSP mappings in board file and good SSP configs in the SoC file.

@macchian

macchian commented Apr 9, 2020

Copy link
Copy Markdown
Contributor Author

Yep, I think that looks right - you have DMIC, SSP mappings in board file and good SSP configs in the SoC file.

Thanks @lgirdwood , since I'm still not able to pulled it, could you help merge this if no fix requires?

@lgirdwood

Copy link
Copy Markdown
Member

SOFCI TEST

@lgirdwood

Copy link
Copy Markdown
Member

@macchian lets re-run CI since it had some fixes recently.

@lgirdwood

Copy link
Copy Markdown
Member

@macchian can you check the CI, seems we have a lot of fail reports on CML

Reuse sof-glk-da7219-kwd by included cml.m4
for sof-cml-da7219-max98357a topology with KWD pipeline enabling

Signed-off-by: Mac Chiang <mac.chiang@intel.com>
@macchian
macchian force-pushed the macchian-cml-008-kwd-v2 branch from 1103fbb to c754c49 Compare April 14, 2020 03:18
@macchian

Copy link
Copy Markdown
Contributor Author

@macchian can you check the CI, seems we have a lot of fail reports on CML

yes, I rebased the code and fixed it. Checking the CI later when it reports.

@macchian

Copy link
Copy Markdown
Contributor Author

@macchian can you check the CI, seems we have a lot of fail reports on CML

yes, I rebased the code and fixed it. Checking the CI later when it reports.

@lgirdwood , I am not able to login the QuickBuild system, could you point out the new failed logs below?

Internal Intel CI System/merge/codecheck — Bugs were found
sof-ci/jenkins/pr-device-test — On-device Test Failed:GLK_BOB_DA7219 APL_UP2_NOCODEC

@lgirdwood

Copy link
Copy Markdown
Member

CI jenkins known issues.

@lgirdwood
lgirdwood merged commit 21b64c0 into thesofproject:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants