Repository navigation
topology: add equalizer to cml rt5682 and hda generic topology - #2444
Merged
Merged
Conversation
fredoh9
force-pushed
the
fix/add_eq_cml_and_hda
branch
from
February 26, 2020 22:07
c061f11 to
d56086f
Compare
lgirdwood
requested changes
Feb 26, 2020
fredoh9
changed the title
singalsu
reviewed
Feb 27, 2020
singalsu
reviewed
Feb 27, 2020
fredoh9
force-pushed
the
fix/add_eq_cml_and_hda
branch
2 times, most recently
from
February 28, 2020 01:24
7209013 to
6c5247c
Compare
fredoh9
changed the title
|
@fredoh9 probably good to separate the changes for different platforms into separate commits. |
Contributor
Author
fredoh9
force-pushed
the
fix/add_eq_cml_and_hda
branch
from
March 4, 2020 22:39
6c5247c to
81bebda
Compare
Contributor
Author
lgirdwood
requested changes
Mar 5, 2020
fredoh9
force-pushed
the
fix/add_eq_cml_and_hda
branch
from
March 13, 2020 06:36
81bebda to
8b97d41
Compare
Contributor
Author
|
@juimonen @singalsu @lgirdwood I updated with makefile changes without making new files. I think this is right and better way to keep EQ topology. What do you think? And we don't need to wait CML topology clean up. I see some build errors in ICL but the error is not relevant. |
lgirdwood
requested changes
Mar 14, 2020
fredoh9
force-pushed
the
fix/add_eq_cml_and_hda
branch
from
March 16, 2020 15:05
8b97d41 to
353449d
Compare
lgirdwood
approved these changes
Mar 16, 2020
Add EQIIR and EQFIR to first playback pipeline. This help to expand more equalizer testing across platforms. Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
fredoh9
force-pushed
the
fix/add_eq_cml_and_hda
branch
from
March 22, 2020 00:01
353449d to
6338126
Compare
Member
|
SOFCI TEST |
xiulipan
suggested changes
Mar 24, 2020
xiulipan
left a comment
xiulipan
left a comment
Contributor
There was a problem hiding this comment.
Only some naming style and intend issue.
Other LGTM
fredoh9
force-pushed
the
fix/add_eq_cml_and_hda
branch
from
March 24, 2020 21:33
6338126 to
db050ef
Compare
Add EQIIR and EQFIR to first playback pipeline. This help to expand more equalizer testing across platforms. Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
xiulipan
approved these changes
Mar 26, 2020
Member
|
Looks like CI is incomplete, lets rerun after server reboot. |
Member
|
SOFCI TEST |
Contributor
Author
|
I checked Internal Intel CI System page, it's false alarm. DEVICE_TEST results look normal as well |
Member
|
@lgirdwood It was a QB issue, since your comment PR was rebuilt and now everything looks fine. |
Contributor
|
@lgirdwood Travis failed to report success. Admin has to merge it. |
Member
|
Travis all green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add EQIIR and EQFIR to first playback pipeline. This help to expand more
equalizer testing across platforms.
Signed-off-by: Fred Oh fred.oh@linux.intel.com
Changes files from sof-cml-rt5682-kwd.m4, sof-cml-rt5682.m4, sof-hda-generic.m4 respectively. One line is changed from pipe-volume-playback.m4 to pipe-eq-volume-playback.m4
Tested in CML Hatch with RT5682 and WHL HDA generic. Plan to expand daily EQ testing with CML_HEL_RT5682, CLF_RVP_HDA, ICL_RVP_HDA.