Skip to content

Clear the -Wall -Wextra warning backlog #161

Closed

Description

@HugoFara

Tracks clearing the -Wall -Wextra backlog enabled in #156. Currently 373 unique GCC warnings:

Warning Count
-Wunused-parameter 314
-Wdeprecated-copy 65
-Wmissing-field-initializers 24
-Wunused-variable 7
-Wreorder 3 sites (harmless)
  • All 65 -Wdeprecated-copy came from FFPoint (fixed in Give FFPoint one way to copy itself #191).
  • Most unused parameters are in the DataLayer subclass headers. Fixing them with [[maybe_unused]] or unnamed parameters is good first-contribution work.

Order: move stb_image_write.h to third_party/ (#192), FFPoint (#191), then decide where the generated colormap.h goes, then the layer headers, then Command.cpp / FireDomain.cpp. Enable FOREFIRE_WARNINGS_AS_ERRORS for each file as it is cleared. Finish this before #164.


Drafted with Claude Opus 5, reviewed by a maintainer.

Activity

  1. added
    refactorCode restructuring without intended behavior changes
    on Aug 12, 2026
  2. filippi commented on Oct 21, 2026

    @filippi
    Contributor

    Why not @HugoFara hope it'll pass on exotic compilers, bu can be custom changed anyway

  3. HugoFara commented on Oct 22, 2026

    @HugoFara
    CollaboratorAuthor

    I compile with clang, I can test with GCC. Except for the -Wreorder, the other flags should be idempotent related to compilers.

    From what we saw recently with the Meso-NH team and pyfortool (Fortran, but same aproach), some false flags were raised but the rest was pretty much old code that needed an update.

  4. antonio-leblanc commented on Oct 28, 2026

    @antonio-leblanc
    Collaborator

    Opened #227 for the reorder and dead variables (286 → 276 unique warnings, GCC 13.3 -Wall -Wextra). Suggestion for the rest:

    Step Warnings Left
    unused-parameter in layer headers (comment out the name) 195 81
    unused-parameter in core .cpp 37 44
    flux/, propagation/, atmoSurf, Farsite leftovers 22 2 (OpenMPI headers)

    The last one touches physics, so it waits for Filippi. The first two are mechanical, Hugo or I can take them.

  5. added theissue type on Oct 29, 2026
  6. antonio-leblanc commented on Oct 29, 2026

    @antonio-leblanc
    Collaborator

    Opened #238 to remove the unused listenMode and mark the MPI headers as SYSTEM (no logic change). After it, 21 unique warnings left (GCC 13.3, -Wall -Wextra, NetCDF + MPI), all in physics code:

    • flux/ models (13) and IsotropicIsospeed (1): unused valueOf/et/at
    • FarsitePropagationModel (5): variables computed and never used
    • CLibForeFire.cpp (2): atmoSurf computed but never used in the coupling, maybe a missing division

    Leaving these for Filippi, since silencing them blindly could hide a real bug.

  7. antonio-leblanc commented on Nov 3, 2026

    @antonio-leblanc
    Collaborator

    #255 marks 18 of the last 21 as [[maybe_unused]]. Left 3 on purpose because they look like real bugs: Farsite.adjustementWind is read but never applied, and atmoSurf is computed but unused in injectedAtGround/spotAtGround.

  8. antonio-leblanc commented on Nov 10, 2026

    @antonio-leblanc
    Collaborator

    Done: #255 and #267 cleared the backlog. 0 warnings with GCC 13.3 -Wall -Wextra, with and without MPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    refactorCode restructuring without intended behavior changes

    Type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions