Repository navigation
refactor: clear unused-variable and reorder warnings (#161) - #227
Merged
Merged
Conversation
Removes variables that were computed and never read, and matches the constructor initializer order of RosLayer and BurningRatioLayer to the member declaration order. No behavior change. - CLibForeFire.cpp: drop two unused atmoSurf lookups - DataBroker.cpp: drop an FFArray that was allocated and leaked - FireDomain.cpp: drop an unused arrival-time lookup in isBurnt - FluxLayer.h: drop the leftover debug block (domID, sumAdded, diffN) - Command.cpp: drop the isoToSeconds lambda that emit never calls - FarsitePropagationModel.cpp: drop the unused rm declaration Left for a separate decision: listenMode in Command.cpp, and adjustementWind, slopespd, react and savx in the Farsite model.
atmoSurf is computed and never used in the coupling outputs injectedAtGround and spotAtGround: it may be a missing division, not dead code. Physics files stay as they are on dev.
antonio-leblanc
requested review from
HugoFara
and removed request for
HugoFara
October 28, 2026 21:35
filippi
approved these changes
Oct 29, 2026
antonio-leblanc
deleted the
refactor/clear-unused-and-reorder-warnings
branch
October 29, 2026 10:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes variables that are computed and never read, and fixes the initializer order in
RosLayer/BurningRatioLayer. No behavior change.Physics and coupling code are left untouched on purpose; those warnings stay for a separate pass.
Unique warnings, GCC 13.3,
-Wall -Wextra, default build (NetCDF + MPI):dev-Wunused-parameter-Wreorder-Wunused-variable-Wunused-but-set-variable-Wcast-function-type(OpenMPI header)