Skip to content

refactor: clear unused-variable and reorder warnings (#161) - #227

Merged
filippi merged 2 commits into
devfrom
refactor/clear-unused-and-reorder-warnings
Oct 29, 2026
Merged

filippi merged 2 commits into
devfrom
refactor/clear-unused-and-reorder-warnings

Conversation

@antonio-leblanc

@antonio-leblanc antonio-leblanc commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Removes variables that are computed and never read, and fixes the initializer order in RosLayer/BurningRatioLayer. No behavior change.

Physics and coupling code are left untouched on purpose; those warnings stay for a separate pass.

Unique warnings, GCC 13.3, -Wall -Wextra, default build (NetCDF + MPI):

Warning dev this PR
-Wunused-parameter 266 266
-Wreorder 6 0
-Wunused-variable 6 3
-Wunused-but-set-variable 6 5
-Wcast-function-type (OpenMPI header) 2 2
Total 286 276

Removes variables that were computed and never read, and matches the
constructor initializer order of RosLayer and BurningRatioLayer to the
member declaration order. No behavior change.

- CLibForeFire.cpp: drop two unused atmoSurf lookups
- DataBroker.cpp: drop an FFArray that was allocated and leaked
- FireDomain.cpp: drop an unused arrival-time lookup in isBurnt
- FluxLayer.h: drop the leftover debug block (domID, sumAdded, diffN)
- Command.cpp: drop the isoToSeconds lambda that emit never calls
- FarsitePropagationModel.cpp: drop the unused rm declaration

Left for a separate decision: listenMode in Command.cpp, and
adjustementWind, slopespd, react and savx in the Farsite model.
atmoSurf is computed and never used in the coupling outputs
injectedAtGround and spotAtGround: it may be a missing division, not
dead code. Physics files stay as they are on dev.
@filippi
filippi merged commit 0e73d9f into dev Oct 29, 2026
6 checks passed
@antonio-leblanc
antonio-leblanc deleted the refactor/clear-unused-and-reorder-warnings branch October 29, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants