You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@filippi: this needs your agreement. Do any of your pipelines use a compiler without C++17 support (GCC < 5)? If so, which machines?
Proposal: raise CMAKE_CXX_STANDARD from 11 to 17 (CMakeLists.txt:59). The code already builds unchanged under C++17 and C++20, and passes the tests under C++20 (22/22, runff OK). GCC 16 defaults to C++20, so today we force the compiler down to C++11.
Meso-NH does not constrain this: it only compiles C_ForeFire_Interface.c and loads libForeFire.so through dlsym. Only the build machines could.
What C++17 gives us:unique_ptr ownership (the root of #159, #160 and the leaks in #162), std::optional instead of the "1234567890" sentinel, [[maybe_unused]] for #161, and std::filesystem.
Activity
filippi commentedon Oct 21, 2026
Yes, good for that, ols mnh < 5.2 will still have option to run old FF anyway
filippi commentedon Oct 21, 2026
thanks @HugoFara