Skip to content

refactor: mark unused physics variables [[maybe_unused]] (#161) - #255

Merged
antonio-leblanc merged 2 commits into
forefireAPI:devfrom
antonio-leblanc:refactor/silence-physics-warnings
Nov 5, 2026
Merged

antonio-leblanc merged 2 commits into
forefireAPI:devfrom
antonio-leblanc:refactor/silence-physics-warnings

Conversation

@antonio-leblanc

@antonio-leblanc antonio-leblanc commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

18 of the last 21 warnings, all in physics code. Marked them [[maybe_unused]], nothing changed, except rm in Farsite, which was declared and never used, so I removed it.

Left 3 warnings on purpose, they might look like real bugs:

  • Farsite.adjustementWind is read but never applied, so setting it has no effect.
  • atmoSurf in injectedAtGround and spotAtGround is computed but never used. Maybe the sum should be divided by it?

@antonio-leblanc
antonio-leblanc merged commit 231a1d3 into forefireAPI:dev Nov 5, 2026
7 checks passed
@antonio-leblanc
antonio-leblanc deleted the refactor/silence-physics-warnings branch November 5, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant