Repository navigation
build: drop unused listenMode, include MPI headers as SYSTEM (#161) - #238
Merged
filippi merged 1 commit intoOct 30, 2026
Merged
Conversation
HugoFara
approved these changes
Oct 29, 2026
HugoFara
left a comment
Collaborator
There was a problem hiding this comment.
Safe, looks like removal of partial implementation
Collaborator
There was a problem hiding this comment.
I think the code never got implemented here, safe to delete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #161, no behavior change.
listenHTTP:listenModewas set but never read; the early return for non-zero MPI domains stays the same.SYSTEMso OpenMPI header warnings stop showing up (24 → 21 unique, GCC 13.3-Wall -Wextra, NetCDF + MPI).