Skip to content

build: drop unused listenMode, include MPI headers as SYSTEM (#161) - #238

Merged
filippi merged 1 commit into
forefireAPI:devfrom
antonio-leblanc:build/warnings-mpi-listen
Oct 30, 2026
Merged

filippi merged 1 commit into
forefireAPI:devfrom
antonio-leblanc:build/warnings-mpi-listen

Conversation

@antonio-leblanc

Copy link
Copy Markdown
Collaborator

Part of #161, no behavior change.

  • listenHTTP: listenMode was set but never read; the early return for non-zero MPI domains stays the same.
  • MPI include dirs marked SYSTEM so OpenMPI header warnings stop showing up (24 → 21 unique, GCC 13.3 -Wall -Wextra, NetCDF + MPI).

@HugoFara HugoFara left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safe, looks like removal of partial implementation

Comment thread src/Command.cpp

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code never got implemented here, safe to delete.

@filippi
filippi merged commit 8623139 into forefireAPI:dev Oct 30, 2026
6 checks passed
@antonio-leblanc
antonio-leblanc deleted the build/warnings-mpi-listen branch October 31, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants