Repository navigation
Conversation
added 7 commits
October 13, 2026 10:03
# Conflicts: # src/lib.rs
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
Included with preserved Git history in PR67 and PR70, now on main 8baf459. This exact PR head was verified as an ancestor before closure. Closing the superseded review; no branch deletion or squash. Final ordinary CI and approved exact-source visual qualification are recorded in PR70. The main Pages workflow is still being monitored, so closure does not claim completed live publication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embedded consumers can now submit real SPH emitter controls and inspect accepted particles with the canonical quantitative diagnostics, or select a real pressure provider and inspect its qualified output, fallback decision, provenance and timings. Both session owners preserve their last published result on rejection/cancellation/deadline and enforce explicit quotas and array budgets.
This PR is stacked on #48, which remains unchanged. It contains full dependency merges of #47 at 1923d5b and #49 at b8ca87c, preserving their history. API implementation commits are
177e800(material) andec9d960(pressure). Only their additivesrc/lib.rsmerge region needed resolution. Main was not merged or deployed.MaterialSessionreusesParticleDiagnostic, separates accepted position time from post-emission/pre-integration diagnostic time, and retains the actual accepted emitter controls/source identity. It exposes raw borrowed slices for CAD/live consumers; no competing VTK exporter or capture type.PressureSessionreusesPressureProviderandProviderReport, supports explicit numerical or preferred-provider-with-reference-fallback selection, and retains immutable qualified pressure after workspace failures. It exposes qualified pressure-stage data, not accepted full-step velocities or an SPH EOS replacement.docs/api/; the persistent plan and exact evidence are indocs/plans/public-simulation-api/.Validation on Linux CPU/Rust 1.92.0, using the real SHA256-verified frozen checkpoint:
One authored high-frequency request failed the model quality gate and exhausted the unchanged 3000-iteration numerical fallback budget. It remains a negative regression proving typed failure and unchanged prior publication; no tolerances were relaxed. The smooth-mode success is not a universal accuracy claim.
Godot binding/runtime, GPU, desktop native graphics/clipboard, ARM/WebAssembly, full trajectories using the new AI provider and target-device timing remain unqualified. Provider-stage timing excludes session publication and other documented host work; no real-time or general speedup promise. CAD #50 retains VTK/rendering ownership; Tuldok v1/v2 dataset completion remains with its existing exporter.
Follow-up at
99bd039: reviewed moving-plate PR #52 atfd281eband recorded a separate M5 library/session integration milestone, including ownership, interval units/signs, immutable publication and platform limits. Moving-plate support is not advertised by this PR. Independent documentation review found no blockers.Hosted CI: research-book run 38383894838 at
ec9d960passed fresh aligned-strain qualification, then refused the educational packet because its historical Cargo.lock pin differs from current main. This branch's Cargo.lock exactly matches starting main2209012; the observed mismatch is independently reproduced. The packet additionally restricts crate-root exports, so it requires a separate source-qualification update; no gate has been weakened. Final-head checks at99bd039are all terminal; details below.Final hosted evidence at
99bd03905a5e4f670328abf12f2fae3a0ee3ab20:cargo test --lockedfor core-only (--no-default-features), default, and desktop (--features desktop) all passed; respectively 345 / 352 / 383 passed, zero failed, two artifact-dependent tests ignored per configuration. These overlap and must not be added together.core-and-executableand executable lifecycle/Python contracts passed.changed qualified native source Cargo.lockrefusal, after fresh native qualification passed. Historical publication-source qualification needs a separate update; this does not imply the later pinned crate-root check would accept new API exports. Deploy was skipped.Working tree clean after push. Main and PR #48 remain unchanged. Hosted desktop tests do not establish native-window/clipboard, GPU, Godot, ARM/WASM or real-time performance support.