Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
Included with preserved Git history in PR67 and PR70, now on main 8baf459. This exact PR head was verified as an ancestor before closure. Closing the superseded review; no branch deletion or squash. Final ordinary CI and approved exact-source visual qualification are recorded in PR70. The main Pages workflow is still being monitored, so closure does not claim completed live publication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This next broader-physics slice adds moving-wall response and finite-mass fluid/solid impulse exchange to Rheon's existing reduced shear geometry. A plate can prescribe a tangential speed or carry finite scalar inertia and recoil from equal/opposite viscous impulse. Fluid and plate velocities publish together only after independent momentum, energy/work and cancellation gates pass.
Stacked on PR #45 (
bbc6089), not main. New head:fd281ebf51d63b5406f86a74cdc67873ea9a0174. The nine-file write set adds one experimental workspace, native example, tests, independent rational checker, focused CI and a standards-planned milestone. It changes no production API/source, renderer, Cargo dependencies or book-owned file. The API contract handoff is indocs/plans/moving-plate-coupling/reports/contract.mdfor API task 01a134aa-6179-75ab-b738-c1db75dbf00d / PR48 (f06a127); the public session adapter remains its owner's decision.The model is one-dimensional tangential Newtonian shear in an invariant/periodic planar channel. Normal geometry stays fixed during plate translation. Borrowed StaticObstacleShear supplies actual layer volumes, centers and no-slip/Navier conductances. A backward-Euler chain solve includes dynamic plate masses and eliminates prescribed endpoints; actual stored output must satisfy each node equation, combined energy plus dissipation equals actuator work, and total momentum changes only by prescribed-wall impulse. Exact disconnected common-translation states are preserved without tolerance snapping.
Quantitative acceptance:
Validation on fd281eb:
cargo test --locked --no-default-features --test plate_coupling_contract --test obstacle_flow_contract --test static_obstacle_contract -- --nocapture: 37 passed.cargo test --locked --test plate_coupling_contract --example plate_coupling: 11 + 4 passed (example repeats interval primitives).cargo fmt --all --check; focused core and all-target default Clippy with-D warnings: passed.python3andpython3 -O tools/check_plate_coupling.py --native ... --output ...: each passed 18 steps and 11 corruption rejections. Receipts:/tmp/rheon-plate-fd281eb-normal/qualification.jsonand/tmp/rheon-plate-fd281eb-optimized/qualification.jsonin the task environment.Supported arithmetic remains Linux x86_64 with default scalar binary64 controls. Other OS/CPU/GPU, general rigid-body orientation/contact/torque, normal wall motion, moving topology, pressure/body loads, liquid interfaces and engineering accuracy are unqualified. No new Lean proof is claimed; the inherited interval backend's arithmetic premise remains explicit. No merge or deployment.
PR45 hosted closure on exact bbc6089: core/default/desktop, executable aggregate, native/rational, Lean and dense3D checks all passed. Book build alone fails the frozen Cargo.lock admission, independently reproduced on unchanged main 2209012; deployment skipped. That shared book issue remains with its owner and no acceptance check is weakened here.
Exact-head hosted evidence
At
fd281ebf51d63b5406f86a74cdc67873ea9a0174, Moving-plate shear coupling run 38383793295 passednative-couplingin 29 seconds: formatting, focused core Clippy, 37 Rust contracts, native build, and normal/optimized independent rational qualification, with source-bound evidence uploaded. Dense3D scoped checks also passed. The inherited full Rust and aligned-Stokes jobs also completed successfully; final details follow.Final inherited CI closure
All checks are complete and successful for head
fd281ebf51d63b5406f86a74cdc67873ea9a0174. Rust matrix run 38383793099 passed strict all-target Clippy andcargo test --lockedfor core-only (351 tests), default (358 tests), and desktop (388 tests); executable smoke/lifecycle checks and the aggregate gate also passed. Counts were read from completed job logs. The temporary merge commitd253b1ba830be7769e6d6d01575c9cbe41710c77has the same tree1610280f8f7a6c5c66cf0c0fb12ac25ae95075e0as the published head.Inherited aligned-Stokes run 38383793101 passed both native-rational and conditional-kernel-contracts. Coupling evidence artifact
11804203818is retained by the dedicated successful run. No source regression or additional commit was needed.PR45's separately reproduced baseline book/Cargo.lock binding failure remains a book/validation-owner dependency. No book workflow was triggered for the PR52-only delta. Remaining implementation dependencies are the API owner's adapter (atomic time/generation publication) and future explicit swept-volume/work and pressure-accuracy contracts before arbitrary moving geometry, pressure loads, rotation or contact can be added. The bounded scope and hardware limitations above are unchanged.