Repository navigation
Integrate and qualify bounded obstacle-flow Stokes experiment - #45
Merged
Merged
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current main has stationary obstacle pressure and strain operators but no retained executable integration of the off-main bounded Stokes transaction. This PR selectively imports that existing experiment from
03dd79561cbba6b5b81737b3f4b4cf5af1e64740onto main2209012, with its interval certificates, rational oracle, rollback tests and conditional proof sources.The new
unit-ringcase circulates through eight wet cells around the central aligned box. Its independent rational control starts at 1 J and reaches 731/1024 J after one 1/32 s step, with zero divergence; three-step native sequences evolve the same caller field. The separate asymmetric curl checks genuine pressure correction. Review found and fixed a sequence-identity gap: qualification now rejects a valid curl sequence substituted for the ring, shortened sequences and changed cadence.Scope is explicitly experimental: one fixed grid-aligned internal box, no-slip solid, sealed free-slip outer walls, constant positive density/viscosity, unforced explicit viscosity and pressure proposal. Production liquid/gas and public API/renderer sources are unchanged. No advection, moving solids, two-way coupling, contact resolution, calibrated drag/stress, continuum convergence or real-time claim. Linux x86_64 with default scalar binary64 controls is the qualified arithmetic boundary; ARM, other OSes and GPU are untested.
docs/broader-physics-milestone.mdrecords candidate inventory, finite acceptance criteria, proposed API controls/data and staged geometry/moving-wall/coupling gates. Existing research's pressure-load bias prevents silently promoting a pressure-to-body load map. Owner work was preserved in the original checkout. No merge or deployment.Validation at bbc6089:
python3 tools/qualify_aligned_stokes.py /tmp/rheon-physics-bbc6089-qualificationPASS on clean committed source: formatting, 49 distinct Rust contracts (57 executions including repeated arithmetic tests in examples), build, targeted Clippy, 13 native single-step cases, two three-step sequences, 374 arithmetic probes, and 18 Python tests each in normal and optimized mode.cargo clippy --locked --no-default-features --all-targets -- -D warningsPASS.cargo test --locked --no-default-featuresPASS: 340 tests across 41 test/doc-test executables, including the existing long material-scene and cancellation regressions.lean_checked: false. Proofs assume sound enclosures and do not establish Rust/IEEE refinement. Hosted artifact downloads returned HTTP 403; local native receipts are available, and hosted success was verified through job metadata and the connector retrieved the detailed Lean log: 19 audited declarations and seven negative probes passed in each Python mode.Generated evidence remains outside Git under the source-bound qualification directory above. This is a finite discrete obstacle-flow milestone, not completion of general physics.
Existing main blocker: book build refuses
changed qualified native source Cargo.lockindocs/education/aligned_strain_packet.py:source_core. The GitHub connector retrieved the detailed job log after CLI download received 403. Independently reproduced by callingsource_corein a fresh detached checkout of unchanged main2209012at/tmp/rheon-physics-main-check. Neither Cargo.lock nor that checker changes in this PR. Its stale frozen-source admission needs the book/validation owner; no acceptance gate is weakened here.Final hosted check status on exact head bbc6089: core-only, default, desktop, executable-contracts and aggregate core-and-executable all PASS, as do native/rational, conditional Lean and dense3D checks. Book build alone FAILS for the independently reproduced pre-existing main frozen Cargo.lock check; deployment SKIPPED. CodeRabbit automatically skipped the draft; independent human-like agent review described above was performed.