Repository navigation
Conversation
added 4 commits
October 13, 2026 10:28
…ll-step-provider-api
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 13, 2026
Owner
Author
|
Included with preserved Git history in PR67 and PR70, now on main 8baf459. This exact PR head was verified as an ancestor before closure. Closing the superseded review; no branch deletion or squash. Final ordinary CI and approved exact-source visual qualification are recorded in PR70. The main Pages workflow is still being monitored, so closure does not claim completed live publication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production consumers can now select a pressure provider through
Simulation,LiquidTransportSimulationandSimulationSessionwhile retaining the real full-step acceptance and rollback path. Previously providers were available only through pressure-stage sessions or the separate trajectory harness.This draft stacks on #53 (
99bd039) and merges complete #49 through89997c5, including its final independent trajectory transition/receipt verifier fixes. The API implementation is3525c97. Provider traits, numerical algorithms and those verifier files are unchanged. Main, PR48 and PR53 remain untouched.ProviderStepWorkspaceand explicit numerical/preferred-with-fallback selection for sealed constant-density boxes. Actual shortened dt reaches the provider's support gate.Validation on Linux CPU/Rust1.92.0 with the SHA256-verified frozen model export (
RHEON_AI_EXPORT):cargo test --release --locked --no-default-features -- --include-ignoredcargo test --release --locked -- --include-ignoredcargo test --release --locked --no-default-features --features parallel --lib --test provider_step_contract --test session_contract -- --include-ignoredCounts overlap across configurations. Strict core/default all-target Clippy, formatting and diff checks passed. Independent review reran 24 unit/integration tests with the real export and earlier 34 affected legacy regressions; no runtime blockers. Its memory-accounting, negative-test and stale-doc findings were addressed.
The production regression accepts 24 intervals, including real-model unsupported-dt fallback at frame9 and final-publication cancellation/retry at frame12. It independently recomputes actual stored-velocity divergence. Other cases cover legacy numerical equivalence, every observed callback, pressure-qualified output rejected by actual divergence, post-pressure liquid numerical failure, unsupported modes, workspace identity and budgets. The production example selected the real model on 24 updates through 0.4s simulated time; this is not a speedup or real-time claim.
Independent validation handoff: task
01a134aa-fa83-76e1-8e5d-87a010e33017should validate3525c979e16629b295a6865e3abbb2a36803cc93, particularly production acceptance/rollback and provider metadata, using the commands above. That external task's result is pending; it is separate from the completed readonly API review.Limits: sealed-box carrier only; no free surface/column/viscosity/boundary-flux provider composition, SPH EOS replacement, general CAD physics, Godot runtime, native graphics/clipboard, GPU, ARM/WASM or target-device performance qualification. Deadlines are cooperative; caller model state is not rolled back. Pressure timing excludes the rest of the step. Dense3D wire formats are unchanged and do not serialize provider provenance.
Hosted checks on the exact head are now terminal; results below. The existing research-book historical source-pin mismatch documented in #53 is not repaired or bypassed here. Nothing merged to main or deployed.
Final hosted status for
3525c979e16629b295a6865e3abbb2a36803cc93:core-and-executablepassed.changed qualified native source Cargo.lock. This is the previously identified inherited publication-source gate; prerequisite repair stays with the book owner. Deploy skipped. Overall PR status is not all green.Monitoring found no API regression and required no code changes or additional pushes. Worktree is clean and the head is unchanged. Reported environment disconnects were checked with successful shell/GitHub reads; no uncertain push was repeated.