Skip to content

feat(api): select pressure providers in production full-step sessions - #55

Closed
MrScripty wants to merge 4 commits into
feat/material-simulation-apifrom
feat/full-step-provider-api
Closed

MrScripty wants to merge 4 commits into
feat/material-simulation-apifrom
feat/full-step-provider-api

Conversation

@MrScripty

@MrScripty MrScripty commented Oct 13, 2026 •

Copy link
Copy Markdown
Owner

Production consumers can now select a pressure provider through Simulation, LiquidTransportSimulation and SimulationSession while retaining the real full-step acceptance and rollback path. Previously providers were available only through pressure-stage sessions or the separate trajectory harness.

This draft stacks on #53 (99bd039) and merges complete #49 through 89997c5, including its final independent trajectory transition/receipt verifier fixes. The API implementation is 3525c97. Provider traits, numerical algorithms and those verifier files are unchanged. Main, PR48 and PR53 remain untouched.

  • Adds a separately capped ProviderStepWorkspace and explicit numerical/preferred-with-fallback selection for sealed constant-density boxes. Actual shortened dt reaches the provider's support gate.
  • Reuses production advection/forces, pressure correction, stored-f32 divergence, Courant, tracer, represented-volume, clock/generation and final publication gates. A later failure rejects the whole step and preserves prior accepted state/provider metadata.
  • Accepted session snapshots expose the exact provider selection/provenance/report for their interval. PressureSession remains pressure-only. Capability version 2 and explicit array accounting distinguish this route from other domains.
  • Adds a bounded 24-update production host example, supported-domain/ownership contract, and a persistent milestone plan.

Validation on Linux CPU/Rust1.92.0 with the SHA256-verified frozen model export (RHEON_AI_EXPORT):

Command Passed Failed / ignored
cargo test --release --locked --no-default-features -- --include-ignored 354 0 / 0
cargo test --release --locked -- --include-ignored 361 0 / 0
cargo test --release --locked --no-default-features --features parallel --lib --test provider_step_contract --test session_contract -- --include-ignored 29 0 / 0

Counts overlap across configurations. Strict core/default all-target Clippy, formatting and diff checks passed. Independent review reran 24 unit/integration tests with the real export and earlier 34 affected legacy regressions; no runtime blockers. Its memory-accounting, negative-test and stale-doc findings were addressed.

The production regression accepts 24 intervals, including real-model unsupported-dt fallback at frame9 and final-publication cancellation/retry at frame12. It independently recomputes actual stored-velocity divergence. Other cases cover legacy numerical equivalence, every observed callback, pressure-qualified output rejected by actual divergence, post-pressure liquid numerical failure, unsupported modes, workspace identity and budgets. The production example selected the real model on 24 updates through 0.4s simulated time; this is not a speedup or real-time claim.

Independent validation handoff: task 01a134aa-fa83-76e1-8e5d-87a010e33017 should validate 3525c979e16629b295a6865e3abbb2a36803cc93, particularly production acceptance/rollback and provider metadata, using the commands above. That external task's result is pending; it is separate from the completed readonly API review.

Limits: sealed-box carrier only; no free surface/column/viscosity/boundary-flux provider composition, SPH EOS replacement, general CAD physics, Godot runtime, native graphics/clipboard, GPU, ARM/WASM or target-device performance qualification. Deadlines are cooperative; caller model state is not rolled back. Pressure timing excludes the rest of the step. Dense3D wire formats are unchanged and do not serialize provider provenance.

Hosted checks on the exact head are now terminal; results below. The existing research-book historical source-pin mismatch documented in #53 is not repaired or bypassed here. Nothing merged to main or deployed.

Final hosted status for 3525c979e16629b295a6865e3abbb2a36803cc93:

  • Rust run 38390095050 passed strict lints and all feature configurations: 351 core-only / 358 default / 389 desktop test passes, zero failures and three artifact-dependent skips per configuration. Counts overlap; local real-artifact runs above cover the skipped tests. Executable contracts and aggregate core-and-executable passed.
  • AI run 38390095071 passed, including final PR49 independent verification of 288 captured / 864 timed trajectory frames and 14 trajectory mutation tests under normal and optimized Python. This remains the provider owner's bounded harness, separately scoped from production-session tests.
  • Independent native/rational run 38390095176 and dense3D runs 38390095031 / 38390010793 passed.
  • Research-book run 38390095085 failed: fresh native qualification passed against this exact head, then the historical educational packet refused changed qualified native source Cargo.lock. This is the previously identified inherited publication-source gate; prerequisite repair stays with the book owner. Deploy skipped. Overall PR status is not all green.
  • CodeRabbit skipped substantive review because this is a draft.

Monitoring found no API regression and required no code changes or additional pushes. Worktree is clean and the head is unchanged. Reported environment disconnects were checked with successful shell/GitHub reads; no uncertain push was repeated.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Owner Author

Included with preserved Git history in PR67 and PR70, now on main 8baf459. This exact PR head was verified as an ancestor before closure. Closing the superseded review; no branch deletion or squash. Final ordinary CI and approved exact-source visual qualification are recorded in PR70. The main Pages workflow is still being monitored, so closure does not claim completed live publication.

@MrScripty MrScripty closed this Oct 14, 2026
@MrScripty
MrScripty deleted the feat/full-step-provider-api branch October 16, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant