Skip to content

feat(emitter): vector velocity, independent motion and seeded perturbations - #57

Closed
MrScripty wants to merge 2 commits into
feat/full-step-provider-apifrom
feat/emitter-vector-turbulence
Closed

MrScripty wants to merge 2 commits into
feat/full-step-provider-apifrom
feat/emitter-vector-turbulence

Conversation

@MrScripty

@MrScripty MrScripty commented Oct 13, 2026 •

Copy link
Copy Markdown
Owner

Emitters can now prescribe a three-dimensional relative velocity, translate independently, and add bounded seeded inlet perturbations. Native controls expose vector XYZ plus direction/speed, separate motion, and seed/strength/spatial/time scales. Existing pressure-head defaults remain supported.

This draft stacks on #55, fixed base 3525c979e16629b295a6865e3abbb2a36803cc93; it does not merge or deploy that series.

Behavior and contracts

  • Shared SI controls drive both carrier forcing and liquid/gas particle births. Positive jet vector defines the tilted cylinder axis; the other end is opposed. A zero vector disables emission.
  • Source motion translates center + absolute_time * motion_velocity and is inherited by new particles. It is not a moving collider.
  • Seeded source-local 4D noise is stateless and norm-bounded. Strength is m/s, spatial scale metres, evolution scale seconds. These are authored inlet disturbances, not validated turbulent physics.
  • Motion and evolution scales bound timestep; invalid/out-of-domain inputs and cancellation preserve accepted state and recorded controls.
  • MaterialSession API/emitter-control versions are 2. Accepted snapshots and frozen desktop requests retain the complete settings. No dense3D wire-format or network changes.
  • New headless emitter_controls example and docs/emitter-controls.md document ownership, units, replay limits and carrier projection semantics.

Validation

Rust 1.92.0, cloud Linux x86_64; all tests use the lockfile. Artifact-inclusive suites set RHEON_AI_EXPORT to the existing real Modal model export.

  • cargo test --release --locked --no-default-features -- --include-ignored: 362 passed, 0 failed/ignored.
  • cargo test --release --locked --features desktop -- --include-ignored: 403 passed, 0 failed/ignored; includes PNG, parallel, work observation and native unit tests.
  • Final emitter contract rerun: 8 passed, including inherited motion in liquid/gas births.
  • Strict all-target Clippy with no-default-features and desktop features, formatting and whitespace checks passed.
  • Headless example: 40 accepted updates, 10 particles, recorded controls and accepted snapshot output.
  • Independent reviewer passed 31 focused/library tests and two native control tests, inspected bounds/rollback/UI/docs, verified example and baseline. No remaining implementation blocker.
  • Pinned-base comparison: byte-identical fields/clock for 12 carrier updates and particle clock/positions/velocities for 4,000 updates each water and air, including births (max 3/max 7). SHA256 9de1cca0c75d98cb5a5986e2f25e358d75d8cbc518bbcc852953276930c9e457. Reproduction harness and exact evidence in docs/plans/emitter-controls/.

Boundaries and coordination

Interactive display/GPU behavior, Godot runtime and hardware performance remain untested. No real-time, validated turbulence or cross-platform bitwise claim. Collision and CPU scheduling implementations remain unchanged; only emitter portions of shared files changed. Parent coordinates collision task 01a13509-edaf-7008-af00-4b8c1e418031 and CPU task 01a13511-af6d-7023-8c01-26adff87302c.

Terminal GitHub checks — final head

Verified final head 1d009e73e430c500122623067cda18664aedba32 on 2026-10-13. All checks are terminal; no implementation-introduced failure or repair was found. The head remains unchanged.

Check Terminal result
Rust feature matrix, executable and aggregate gate PASS: core 359, default 366, desktop 400 tests; each 0 failures and 3 artifact-dependent ignores. All strict lints, formatting, executable contracts and aggregate gate passed.
Real AI checkpoint qualification PASS: real-checkpoint/failure contracts, independent replay, bounded trajectories including 864 timed frames, 14 verifier tests in both normal and optimized Python.
Rational aligned-strain check PASS
dense3D pull-request check and push check PASS
Research-book build FAIL, separately owned source binding: aligned_strain_oracle.Refusal: changed qualified native source Cargo.lock. Book deployment skipped.

The three ignored Rust-matrix cases require a model artifact; they passed in the local artifact-inclusive suites reported above. Matrix success does not imply the book is qualified. Cargo.lock and docs/education/aligned_strain_packet.py have no diff from fixed PR55 base 3525c97; the source-binding refusal also occurred on that base. Its checker/evidence was neither weakened nor automatically refreshed. This remains a book-owner integration prerequisite.

Native desktop CI is headless test coverage, not interactive-display/GPU qualification or hardware timing. No merge or deployment performed.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Owner Author

Included with preserved Git history in PR67 and PR70, now on main 8baf459. This exact PR head was verified as an ancestor before closure. Closing the superseded review; no branch deletion or squash. Final ordinary CI and approved exact-source visual qualification are recorded in PR70. The main Pages workflow is still being monitored, so closure does not claim completed live publication.

@MrScripty MrScripty closed this Oct 14, 2026
@MrScripty
MrScripty deleted the feat/emitter-vector-turbulence branch October 16, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant