Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
Included with preserved Git history in PR67 and PR70, now on main 8baf459. This exact PR head was verified as an ancestor before closure. Closing the superseded review; no branch deletion or squash. Final ordinary CI and approved exact-source visual qualification are recorded in PR70. The main Pages workflow is still being monitored, so closure does not claim completed live publication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emitters can now prescribe a three-dimensional relative velocity, translate independently, and add bounded seeded inlet perturbations. Native controls expose vector XYZ plus direction/speed, separate motion, and seed/strength/spatial/time scales. Existing pressure-head defaults remain supported.
This draft stacks on #55, fixed base
3525c979e16629b295a6865e3abbb2a36803cc93; it does not merge or deploy that series.Behavior and contracts
center + absolute_time * motion_velocityand is inherited by new particles. It is not a moving collider.emitter_controlsexample anddocs/emitter-controls.mddocument ownership, units, replay limits and carrier projection semantics.Validation
Rust 1.92.0, cloud Linux x86_64; all tests use the lockfile. Artifact-inclusive suites set
RHEON_AI_EXPORTto the existing real Modal model export.cargo test --release --locked --no-default-features -- --include-ignored: 362 passed, 0 failed/ignored.cargo test --release --locked --features desktop -- --include-ignored: 403 passed, 0 failed/ignored; includes PNG, parallel, work observation and native unit tests.9de1cca0c75d98cb5a5986e2f25e358d75d8cbc518bbcc852953276930c9e457. Reproduction harness and exact evidence indocs/plans/emitter-controls/.Boundaries and coordination
Interactive display/GPU behavior, Godot runtime and hardware performance remain untested. No real-time, validated turbulence or cross-platform bitwise claim. Collision and CPU scheduling implementations remain unchanged; only emitter portions of shared files changed. Parent coordinates collision task
01a13509-edaf-7008-af00-4b8c1e418031and CPU task01a13511-af6d-7023-8c01-26adff87302c.Terminal GitHub checks — final head
Verified final head
1d009e73e430c500122623067cda18664aedba32on 2026-10-13. All checks are terminal; no implementation-introduced failure or repair was found. The head remains unchanged.aligned_strain_oracle.Refusal: changed qualified native source Cargo.lock. Book deployment skipped.The three ignored Rust-matrix cases require a model artifact; they passed in the local artifact-inclusive suites reported above. Matrix success does not imply the book is qualified.
Cargo.lockanddocs/education/aligned_strain_packet.pyhave no diff from fixed PR55 base 3525c97; the source-binding refusal also occurred on that base. Its checker/evidence was neither weakened nor automatically refreshed. This remains a book-owner integration prerequisite.Native desktop CI is headless test coverage, not interactive-display/GPU qualification or hardware timing. No merge or deployment performed.