Repository navigation
feat(desktop): add quantitative obstacle projection lab - #50
Merged
Merged
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop's existing voxel preview stores appearance bytes rather than quantitative fields. This adds a separate obstacle projection lab backed by an accepted
StaticObstaclePressureresult, so users can inspect numerical data without assigning invented pressure or velocity to the particle preview.The lab provides XY/XZ/YZ cell slices, exact cell probes, solid masks, scaled velocity overlays, full-state scalar legends, explicit Pa gauge references, preserved physical aspect ratios, and an independent camera. It deliberately demonstrates one sealed stationary projection with aligned geometry; it does not claim an advancing wake, viscous wall loads, or live particle pressure.
PR43 contracts drive the field distinctions.
docs/implementation/cad-obstacle-lab.mdrecords acceptance criteria, the exact scenario, and remaining shared API/inspection and VTK milestones. Shared-file integration is limited to the two-line desktop module declaration; no history, public API, numerical solver, or settings code is changed.Validation: 25 standalone desktop tests passed in an isolated serial run; 26 passed in a forced temporary integration build with PR47 (
1923d5b), including its inspector test. 16 existing obstacle-flow contracts also passed. Final all-target desktop Clippy with warnings denied, formatting, and diff checks passed. Independent code/screenshot review passed after fixing vector overpainting. A broad debug physics run was interrupted during an existing long-running contract and is not claimed as a full-suite pass. Concurrent worker-lifecycle timing failures disappeared in the isolated serial run; no thresholds were changed.PR47 integration had one patch conflict in the initial module block, resolved only in the temporary worktree by retaining both declarations. The actual combined app completed 1,024 material steps; expanded inspector fields/totals/history remained intact while the timeline was scrubbed and the independent obstacle lab displayed pressure. No inspector implementation is included or overwritten in this standalone branch. Native screenshots were inspected on a dummy Xorg display using software OpenGL at 1250×820 and 900×650. Hardware GPUs, physical touchpads, other OSes, and accelerated rendering are untested. Generated screenshots/logs stay outside commits per repository policy.
Known combined UI caveat: the movable inspector overlaps part of the CAD controls/labels and narrow footer until moved or collapsed. A shared dock layout remains a follow-on. No merge or deployment performed.