Repository navigation
feat: committed particle diagnostics and numerical inspector - #47
Merged
Merged
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Particle pressure/force scratch can be overwritten by failed attempts, and voxel history cannot recover numerical particle state. This adds budgeted committed diagnostics and a separate latest-state numerical inspector while preserving the visual scrubber and CAD renderer.
ParticleDiagnosticandparticle_diagnostics() -> Option<(f64, &[ParticleDiagnostic])>are narrow accessors for the API owner to wrap; no competing public snapshot schema. Shared edits are one lib re-export, a LiveHistory store, two capture calls and the inspector window/module declaration.Validation:
cargo test --release --locked --no-default-features: 326 passed.cargo test --locked --no-default-features --lib: 14 passed.cargo test --locked --no-default-features --test particle_inspection_contract: passed.cargo test --locked --features desktop --bin rheon-desktop inspector::: passed.cargo test --locked --features desktop --bin rheon-desktop -- --test-threads=1: 21 passed after competing jobs finished.cargo clippy --locked --features desktop --all-targets -- -D warnings;cargo fmt --all --check: passed.Earlier desktop runs hit the existing ten-second carrier lifecycle timeout under CPU contention; untouched main
2209012reproduced it. Broad debug numerical testing was stopped in favor of the completed optimized suite. Native graphics, OS clipboard delivery, GPU/driver behavior and real-time performance remain untested. Carrier field snapshots remain with the API workstream; this PR owns particle numerical inspection only.Runnable checkpoint:
cargo run --locked --release --features desktop --bin rheon-desktop, start a material run, expand Numerical inspector. Seedocs/implementation/quantitative-inspection.mdfor milestone acceptance, memory accounting, stage contracts and boundaries. No merge or deployment.