Repository navigation
Tidepool sync 2026-10-12 - #2571
Merged
Merged
Conversation
…& Fix LoopStatusModal Time Ago (#929) * [LOOP-5874] Remove Unused CorrectionRangeInformationView * [LOOP-5769] Fix Loop Status Modal Time Ago
* Remove IPHONEOS_DEPLOYMENT_TARGET from project; will be set at LoopWorkspace scope via xcconfig * Set default IOS deployement target
* Working commit * Updates/Fixes for iOS 27 & Liquid Glass Toolbar * Update Info.plist * Update Info.plist
…indow (#945) CarbMath.map(to:) preconditionFailures if the insulin-sensitivity or carb-ratio timeline doesn't cover a carb entry's start date. The carb-ratio window and carb entries both extend back to carbsStart (baseTime - dateAdjustmentPast), but the ISF window came from timelineIntervalForSensitivity, which is derived from dose and glucose history only. When that history is more recent than carbsStart (e.g. a CGM gap, fresh setup, or a heavily backdated carb entry on the manual-bolus screen), an older carb entry has carb-ratio coverage but no ISF coverage -> closestPrior returns nil -> crash (seen via recommendManualBolus). Extend the ISF and override history back to min(neededSensitivityTimeline.start, carbsStart) so it covers the same carb window as carbRatio.
Brings in LOOP-5903 (IOB to 2 decimal places), LOOP-5769 (">1h ago" in the
loop status modal), LOOP-5733 (watch Last Loop when the phone is unreachable),
LOOP-5951 (tinted critical alert icon), KELP-83 (skip chart redraw when the
prediction is unchanged), basal reissue tests, and removal of the unused
CorrectionRangeInformationView.
The iOS 27 scene, toolbar and plugin picker work was already ported to next-dev
and built on since, so conflicts in AppDelegate, SceneDelegate, LoopAppManager,
SettingsView, StatusTableView and IOSFocusModesView keep the next-dev side.
The minimum iOS version stays at 17.6; the per-project deployment target
settings are dropped in favour of Loop.xcconfig, as upstream did.
Reverts e7a1e21 so the preset history screens are reachable again.
Drops the LOOP-5733 change from the Tidepool merge, which replaced the last loop time with "- - -" whenever the phone is out of reach.
ps2
added a commit
to LoopKit/LoopWorkspace
that referenced
this pull request
Oct 15, 2026
…s, device models (#534) * Bump Loop, LoopKit and LoopAlgorithm (Tidepool sync 2026-10-12) Loop b16e8f43 (LoopKit/Loop#2571), LoopKit 9092a78c (LoopKit/LoopKit#642) and LoopAlgorithm 7ef6724 (LoopKit/LoopAlgorithm#9) merge tidepool-org dev/main. All other Tidepool forks had nothing new since the 2026-05-11 sync. Records the sync and the two new DIY divergences in the sync dev notes. * Bump submodules for backfill tagging, analytics and fixes Bumps CGMBLEKit, EversenseKit, G7SensorKit, LibreLoop, LibreTransmitter, Loop, LoopKit, LoopSupport, NightscoutService, OmnipodKit, RileyLinkKit and TidepoolService to their base branch tips, and NightscoutKit to main (8ae3e6e). * Bump Loop, OmnipodKit, LibreLoop and EversenseKit for device models in analytics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges tidepool-org/Loop
dev(b2cf4b6) intonext-dev. Needs the matching LoopKit/LoopKit sync PR (tidepool-sync/2026-10-12) forUIImage.tintedForTextAttachment.From Tidepool:
CorrectionRangeInformationView(LoopKitUI has the one in use)Conflict resolution:
next-devand built on since, soAppDelegate,SceneDelegate,LoopAppManager,SettingsView,StatusTableViewandIOSFocusModesViewkeep thenext-devside.IPHONEOS_DEPLOYMENT_TARGETsettings are dropped in favour ofLoop.xcconfig, as upstream did..stringsreferences are not re-added.Not taken:
Also in this PR, not from Tidepool:
Tested: full LoopWorkspace simulator build succeeds. The new
TempBasalRecommendationTestscompile but were not run locally, and the restored Performance History screen has not been exercised in the simulator.Please merge with a merge commit rather than squashing, so the Tidepool history stays an ancestor for the next sync.