Repository navigation
”.” Instead of ”,” #940
Description
Describe the bug
When installing on iPhone 5s iOS 12.1 Swedish language swedish keyboard there Will be no ”,” in loop resulting in not being able to give bolus (unless even units) it also produces a round (up) error if typing 1.6 that’ll result in 2,0. (Max bolus max basal etc)
“Work around” I removed Swedish keyboard replacing with English. That did not solve issue.
I changed phones language to English that resolved the issue.
But preferably it should work with “.” As well as “,” or force it to be “,”
Attach an Issue Report
Tap the Loop settings icon on the bottom of the screen, then tap Issue Report and attach it to this ticket.
To Reproduce
Steps to reproduce the behavior:
Others tried to set language and keyboard to Swedish but did not succeed in replicating issue unless it was already on the phone.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Phone
- Hardware: IPhone 5s
- OS Version: iOS 12.1
Loop Version
- Version Number: [e.g. 1.9.2]
- Repo: [LoopKit/Loop, omnipod branch
CGM
- Device: Dexcom G6
- Manager app: Dexcom App
Pump
- Manufacturer: omnipod
- Model: Eros
- Firmware version:
Additional context
Add any other context about the problem here.
Activity
benfiscal commentedon Apr 29, 2019
A work around for me was to set the "Region setting" to USA.
yuri-zhuk commentedon May 6, 2019
Same issue with Russian, iPhone 7, iOS12.2.
Localisation is fine in other places, but not on the bolusing form.
vpdn commentedon May 12, 2019
Anyone can add more details how to reproduce the error? I can have a look, but don't see the error. Setting the region to swedish shows a proper "," in my case.
reelman commentedon May 24, 2019
Since I'm using Loop - so it's 1.9.3 version I haven't got this type off issue. Only thing is that placeholder says "0.0" instead of "0,0" for my locale.
yuri-zhuk commentedon Jun 5, 2019
The phone language in my case is set to Russian, and on this screen instead of ',' there is '.' on the keyboard. The bolus with '.' (such as '1.6') is not accepted. I suspect changing the phone language to English would fix this, but cannot try now - not near my kid. Anyway, her phone needs to stay in Russian.
I'd appreciate if someone could at least point me to the place in the code where this view is implemented. This is a real pain in cases when no bolus is recommended, and I need to make a fractional one anyway.
reelman commentedon Jun 5, 2019
Looks fine for me or am I wrong.
yuri-zhuk commentedon Jun 5, 2019
Weird. I'll have another look tonight and try to provide more details. Can you actually administer a bolus, e.g. 0,1?
reelman commentedon Jun 5, 2019
Yes, all is OK. I can't even enter dot.
I would go with the new version if yours is old. I'm on 1.10.0dev
yuri-zhuk commentedon Jun 5, 2019
We're on master 1.9.4, I believe. Could be the reason.
Kdisimone commentedon Jun 5, 2019
I have found iOS is a bit glitchy on keyboard selections sometimes if you’ve had a language installed. Even if you switch back to a different language, sometimes the old language’s keyboard still appears randomly. The solution is that you have to go into your iPhone settings and remove the old language’s keyboard. Changing languages doesn’t delete the keyboard, and sometimes that old keyboard just gets used.
When I was testing translations for loop a lot, my keyboard would often be in Spanish or Chinese when using other apps, even if my language was set to English again. It’s an iOS thing.
yuzhuk commentedon Jun 5, 2019
Ok, I’ve done some testing and the issue is pretty simple:
It looks like iOS always selects the English keyboard if it’s present under Keyboards in Settings -> General, and so there’s always ‘.’ in the bolus dialog.
If I remove the English keyboard leaving only the Russian one, then it presents the latter and I get the ‘,’ and can enter a fractional bolus.
Weird, since it works fine in other dialogs...
yuzhuk commentedon Jun 5, 2019
Ok, I jumped the gun on my conclusions. Just now I went to bolus her and it’s magically fine even with both keyboards in settings. So yeah, as Katie said it’s iOS taking it’s time to sort it out.
That said, the order of the keyboards is now reversed with the Russian above English - that’s probably what’s making it work now.
Kdisimone commentedon Oct 9, 2019
@yuzhuk you can set your keyboard preferences in iphone settings, General, Keyboards and then select edit. That will shows three horizontal lines on the right side of each keyboard row, and you can drag the row you'd like to be the first choice to the top of your list. Sounds like everything is addressed, so I'll close this issue now.
yuzhuk commentedon Oct 10, 2019
@Kdisimone, thanks. I have since figured out that iOS always uses the last used language set on the keyboard anywhere in the system. The keyboard order in the Settings is irrelevant. So if I've used English somewhere, e.g. in Safari - that's what will come up in Loop on the numeric pad. As such it is an iOS flaw that language cannot be changed on this keyboard view. When it happens, I have to go somewhere else (usually iOS search), change the language back on the alphabet keyboard, and then return to Loop to bolus.
Anyway, I don't mind this issue being closed.
[LOOP-5957] Replace SimpleBolusView and BolusEntryView "X" dismiss wi…