Skip to content

Setting Carb Ratio to 0g/u will crash loop sporadicaly #941

Closed

Description

@micro17

Hi
at first setup i set the carb rating to 0 as i was not sure. When set to 0 loop is crashing every time I opened it. Reproducible.

Thanks

Max

Activity

  1. RobCvdV commented on Nov 8, 2019

    @RobCvdV

    O dear. That is also very dangerous. Setting a zero ratio for carb ratios or insuline sensitivity will make loop think you need an infinite amount of insuline. Read the docs carefully. It's a good thing loop crashed or else you might have.

  2. marionbarker commented on Sep 1, 2021

    @marionbarker
    Contributor

    I tested this so I could recommend closure.

    • I started to do the test on my real phone running v2.2.5 instead of my backup phone.
    • I thought I had backed out the modification, but evidently it got saved.
    • I got a notification 20 min later that phone was not looping and Loop crashed upon opening several times.
    • I tried a few minutes later and I was able to open my real phone and remove the 0 u/g row so no harm done except an adrenaline spike.

    In the meantime, verified with new build of v2.2.5 to my backup phone that a CR of 0 is accepted. In this case, there was no crash, but prediction says "Eventually NaN" as you'd expect when dividing by zero. This was using simulated pump and CGM.

    This error will not be possible with the version being developed in dev.

    If there are any updates to Loop in the interim, seems like guard-rails for CR (like the ones previously added for ISF) should be present.

  3. added
    fixed-in-devFixed in dev (close when dev is released)
    on Dec 7, 2022
  4. github-actions commented on Nov 8, 2023

    @github-actions

    This issue is stale because it has been open for 30 days with no activity.

  5. github-actions commented on Nov 22, 2023

    @github-actions

    This issue was closed because it has been inactive for 14 days since being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixed-in-devFixed in dev (close when dev is released)stale

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions