Skip to content

topology1: add support for HP Omen 16 - #5974

Merged
lgirdwood merged 4 commits into
thesofproject:mainfrom
plbossart:fix/hp-omen16
Jul 12, 2022
Merged

topology1: add support for HP Omen 16#5974
lgirdwood merged 4 commits into
thesofproject:mainfrom
plbossart:fix/hp-omen16

Conversation

@plbossart

@plbossart plbossart commented Jun 30, 2022

Copy link
Copy Markdown
Member

@marc-hb

marc-hb commented Jul 1, 2022

Copy link
Copy Markdown
Collaborator

2 devices unavailable in https://sof-ci.01.org/sofpr/PR5974/build788/devicetest/ because a temporary lab issue. Everything else green

@marc-hb

marc-hb commented Jul 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

SOFCI TEST

Everything green (or blue) in https://sof-ci.01.org/sofpr/PR5974/build802/devicetest

@lgirdwood

lgirdwood commented Jul 4, 2022

Copy link
Copy Markdown
Member

@plbossart CI is good but I assume we are pending on the PR being tested on the device ?

@plbossart

plbossart commented Jul 5, 2022

Copy link
Copy Markdown
Member Author

@plbossart CI is good but I assume we are pending on the PR being tested on the device ?

yep, something is not working apparently see thesofproject/linux#3727

[    5.782321] sof-audio-pci-intel-tgl 0000:00:1f.3: tplg: ready widget id 16 pipe 3 type 27 name : ALH770.OUT stream SDW1-Playback
[    5.782324] sof-audio-pci-intel-tgl 0000:00:1f.3: error: can't connect DAI ALH770.OUT stream SDW1-Playback
[    5.782326] sof-audio-pci-intel-tgl 0000:00:1f.3: error: failed to add widget id 0 type 27 name : ALH770.OUT stream SDW1-Playback

@plbossart
plbossart requested review from RanderWang and ranj063 July 6, 2022 13:38
@plbossart
plbossart marked this pull request as ready for review July 6, 2022 13:38
@plbossart

plbossart commented Jul 6, 2022

Copy link
Copy Markdown
Member Author

This PR was tested successfully, we had to remove one hard-coded assumption that ADL always relies on BT_OFFLOAD (this is only for Chromebooks) and account for the amplifier reference that's required for RT1316.

@RanderWang @ranj063 @bardliao please recheck.

@plbossart plbossart mentioned this pull request Jul 6, 2022
Merged
@lgirdwood

lgirdwood commented Jul 6, 2022

Copy link
Copy Markdown
Member

SOFCI TEST

@lgirdwood

lgirdwood commented Jul 6, 2022

Copy link
Copy Markdown
Member

Some failures on ADL xtos - rerun to be sure.

RanderWang
RanderWang reviewed Jul 7, 2022
View reviewed changes
Comment thread tools/topology/topology1/sof-tgl-rt711-rt1308.m4 Outdated
@marc-hb
marc-hb removed their request for review July 7, 2022 05:38
bardliao
bardliao reviewed Jul 7, 2022
View reviewed changes
Comment thread tools/topology/topology1/CMakeLists.txt Outdated
plbossart added 3 commits July 11, 2022 13:03
@plbossart
topology1: sof-tgl-rt711-rt1308: make amplifier link configuration
4d212e3 
HP Omen 16 devices have an amplifier on link3, add the required
configuration macro.

BugLink: thesofproject/linux#3727
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart
topology1: CMakeLists: add topology for HP Omen 16
b813bc2 
RT711 on link0 and RT1316 on link3.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart
topology1: sof-tgl-rt711-rt1308: make BT_OFFLOAD a CMakeFiles parameter
0a9b092 
Somehow we assumed that all ADL platforms support BT_OFFLOAD. Wrong,
this is only valid for Chromebooks and needs to be set externally in
the CMakeFiles definitions.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart
topology1: sof-tgl-rt711-rt1308: use EXT_AMP_REF for rt1316
282076c 
RT1316 is exposed by the machine driver as having an echo reference,
so the indices are different from the regular ones.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
aiChaoSONG
aiChaoSONG approved these changes Jul 12, 2022
View reviewed changes

@aiChaoSONG aiChaoSONG left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a single unrelated timeout.

@lgirdwood
lgirdwood merged commit 4be016b into thesofproject:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bardliao bardliao bardliao approved these changes
@lgirdwood lgirdwood lgirdwood approved these changes
@libinyang libinyang Awaiting requested review from libinyang
@ranj063 ranj063 Awaiting requested review from ranj063 ranj063 is a code owner
@aborisovich aborisovich Awaiting requested review from aborisovich
@mmaka1 mmaka1 Awaiting requested review from mmaka1
@lbetlej lbetlej Awaiting requested review from lbetlej
@dbaluta dbaluta Awaiting requested review from dbaluta
+2 more reviewers
@RanderWang RanderWang RanderWang approved these changes
@aiChaoSONG aiChaoSONG aiChaoSONG approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@plbossart @marc-hb @lgirdwood @ranj063 @bardliao @RanderWang @aiChaoSONG