Repository navigation
SoundWire: add quirks for HP Omen 16-k0005TX - #3730
Merged
plbossart merged 5 commits intoJul 12, 2022
Merged
Conversation
|
SOFCI TEST |
plbossart
force-pushed
the
sdw/add-version-number
branch
3 times, most recently
from
July 1, 2022 16:25
990bc44 to
b5e9277
Compare
plbossart
force-pushed
the
sdw/add-version-number
branch
from
July 6, 2022 14:11
7af1dd7 to
3513e3e
Compare
plbossart
changed the title
plbossart
marked this pull request as ready for review
July 11, 2022 17:06
plbossart
requested review from
RanderWang,
ajitkupandey,
bardliao,
dbaluta,
jack-cy-yu,
kuanhsuncheng,
kv2019i,
lgirdwood,
libinyang,
oder-chiou,
ranj063,
ryans-lee,
shumingfan,
ujfalusi and
yaochunhung
as code owners
July 11, 2022 17:06
plbossart
force-pushed
the
sdw/add-version-number
branch
from
July 11, 2022 17:06
3513e3e to
7cd7a52
Compare
ranj063
reviewed
Jul 11, 2022
While tinkering with ACPI work-arounds for the HP Omen 16 support, we identified a corner case where the headset codec device properties are not set in the codec .init when -EPROBE_DEFER is returned, but released unconditionally in the .exit(). This leads to a kernel oops [ 4.186891] sof_sdw sof_sdw: snd_soc_register_card failed -517 [ 4.186896] BUG: kernel NULL pointer dereference, address: 00000000000003f0 [ 4.186914] Oops: 0000 [#1] PREEMPT SMP NOPTI [ 4.186926] RIP: 0010:dev_fwnode+0x5/0x20 [ 4.186974] device_remove_software_node+0x10/0x80 [ 4.186982] sof_sdw_rt711_exit+0x19/0x30 [snd_soc_sof_sdw] [ 4.186990] mc_dailink_exit_loop+0x94/0xc0 [snd_soc_sof_sdw] [ 4.186996] ? rt711_rtd_init+0x170/0x170 [snd_soc_sof_sdw] A similar error case can occur if the addition of the device property fails. We need to test if the property was successfully added before removing it. BugLink: thesofproject#3727 Fixes: 768ad6d ("ASoC: Intel: sof_sdw: handle errors on card registration") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
The DSDT for this device has a number of problems: a) it lists rt711 on link0 and link1, but link1 is disabled b) the rt711 entry on link0 uses the wrong v2 instead of v3 (SDCA) c) the rt1316 amplifier on link3 is not listed. Add a remapping table to work-around these BIOS shenanigans. BugLink: https://github.com/thesofproject/sof/issues/5955 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
This device has an RT711-SDCA headset codec on link0 and an RT1316 amplifier on link3. BugLink: https://github.com/thesofproject/sof/issues/5955 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
The JD2 jack detection was selected based on similar settings from other platforms based on RT711-SDCA. BugLink: https://github.com/thesofproject/sof/issues/5955 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
When PCH-attached DMICs are used on a SoundWire-based platform, all known devices pin-mux SoundWire link2 and link3 with DMIC, and only use link0 and link1 for SoundWire. The HP Omen16 is the first exception to the rule, with SoundWire using link0 and link3. Rather than using a fixed mask, let's count the number of SoundWire links used. BugLink: thesofproject/sof#5966 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
force-pushed
the
sdw/add-version-number
branch
from
July 11, 2022 21:36
7cd7a52 to
64a99b8
Compare
ranj063
approved these changes
Jul 11, 2022
bardliao
approved these changes
Jul 12, 2022
Member
Author
|
SOFCI TEST |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set of patches to get audio support on HP Omen 16 SoundWire device
BugLink: #3727
Companion topology fix:
thesofproject/sof#5974
We still need to check the jack detection (JD1 v. JD2)