Skip to content

[FEATURE] Add support for sof-adl-rt711-2ch on HP Omen 16-k0005TX #3727

Closed
Closed
[FEATURE] Add support for sof-adl-rt711-2ch on HP Omen 16-k0005TX#3727
Labels
codecCodec HW or driver restrictionenhancementNew feature or requesttopologyIssues caused by topology

Description

@AlecJY
AlecJY
opened on Jun 28, 2022

Is your feature request related to a problem? Please describe.
I bought an HP Omen 16-k0005TX recently. The soundcard didn't work on Linux. I try to reload snd_sof_pci_intel_tgl then dmesg shows the following messages that sof-adl-rt711-2ch.tplg is not found.

[  390.982490] sof-audio-pci-intel-tgl 0000:00:1f.3: DSP detected with PCI class/subclass/prog-if info 0x040100
[  390.982512] sof-audio-pci-intel-tgl 0000:00:1f.3: SoundWire enabled on CannonLake+ platform, using SOF driver
[  390.982704] sof-audio-pci-intel-tgl 0000:00:1f.3: DSP detected with PCI class/subclass/prog-if 0x040100
[  390.982791] sof-audio-pci-intel-tgl 0000:00:1f.3: bound 0000:00:02.0 (ops i915_audio_component_bind_ops [i915])
[  390.989168] sof-audio-pci-intel-tgl 0000:00:1f.3: use msi interrupt mode
[  391.005236] sof-audio-pci-intel-tgl 0000:00:1f.3: DMICs detected in NHLT tables: 2
[  391.005242] sof-audio-pci-intel-tgl 0000:00:1f.3: hda codecs found, mask 4
[  391.005415] sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware info: version 2:1:1-3964a
[  391.005417] sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware: ABI 3:21:0 Kernel ABI 3:19:1
[  391.005419] sof-audio-pci-intel-tgl 0000:00:1f.3: warn: FW ABI is more recent than kernel
[  391.005423] sof-audio-pci-intel-tgl 0000:00:1f.3: unknown sof_ext_man header type 3 size 0x30
[  391.120009] sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware info: version 2:1:1-3964a
[  391.120028] sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware: ABI 3:21:0 Kernel ABI 3:19:1
[  391.120036] sof-audio-pci-intel-tgl 0000:00:1f.3: warn: FW ABI is more recent than kernel
[  391.125025] soundwire sdw-master-0: Slave Entry not found
[  391.125525] soundwire sdw-master-1: Slave Entry not found
[  391.133608] sof-audio-pci-intel-tgl 0000:00:1f.3: Direct firmware load for intel/sof-tplg/sof-adl-rt711-2ch.tplg failed with error -2
[  391.133618] sof-audio-pci-intel-tgl 0000:00:1f.3: error: tplg request firmware intel/sof-tplg/sof-adl-rt711-2ch.tplg failed err: -2
[  391.133628] sof-audio-pci-intel-tgl 0000:00:1f.3: you may need to download the firmware from https://github.com/thesofproject/sof-bin/
[  391.133631] sof-audio-pci-intel-tgl 0000:00:1f.3: error: failed to load DSP topology -2
[  391.133634] sof-audio-pci-intel-tgl 0000:00:1f.3: ASoC: error at snd_soc_component_probe on 0000:00:1f.3: -2
[  391.133650] sof_sdw sof_sdw: ASoC: failed to instantiate card -2
[  391.133775] sof_sdw sof_sdw: snd_soc_register_card failed -2
[  391.133779] sof_sdw: probe of sof_sdw failed with error -2
[  393.157068] soundwire sdw:3:025d:1316:01:0: Probe not complete, timed out
[  393.157103] soundwire sdw:3:025d:1316:01:0: Update Slave status failed:-110
[  393.157144] soundwire sdw:0:025d:0711:01:0: Probe not complete, timed out
[  393.157153] soundwire sdw:0:025d:0711:01:0: Update Slave status failed:-110

I also tried with renaming sof-adl-rt711.tplg and sof-adl-rt711-4ch.tplg to sof-adl-rt711-2ch.tplg, but it still didn't work. The following is the dmesg log.

[ 1811.139617] sof-audio-pci-intel-tgl 0000:00:1f.3: DSP detected with PCI class/subclass/prog-if info 0x040100
[ 1811.139652] sof-audio-pci-intel-tgl 0000:00:1f.3: SoundWire enabled on CannonLake+ platform, using SOF driver
[ 1811.139984] sof-audio-pci-intel-tgl 0000:00:1f.3: DSP detected with PCI class/subclass/prog-if 0x040100
[ 1811.140102] sof-audio-pci-intel-tgl 0000:00:1f.3: bound 0000:00:02.0 (ops i915_audio_component_bind_ops [i915])
[ 1811.146769] sof-audio-pci-intel-tgl 0000:00:1f.3: use msi interrupt mode
[ 1811.162141] sof-audio-pci-intel-tgl 0000:00:1f.3: DMICs detected in NHLT tables: 2
[ 1811.162145] sof-audio-pci-intel-tgl 0000:00:1f.3: hda codecs found, mask 4
[ 1811.162336] sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware info: version 2:1:1-3964a
[ 1811.162338] sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware: ABI 3:21:0 Kernel ABI 3:19:1
[ 1811.162340] sof-audio-pci-intel-tgl 0000:00:1f.3: warn: FW ABI is more recent than kernel
[ 1811.162343] sof-audio-pci-intel-tgl 0000:00:1f.3: unknown sof_ext_man header type 3 size 0x30
[ 1811.276182] sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware info: version 2:1:1-3964a
[ 1811.276202] sof-audio-pci-intel-tgl 0000:00:1f.3: Firmware: ABI 3:21:0 Kernel ABI 3:19:1
[ 1811.276210] sof-audio-pci-intel-tgl 0000:00:1f.3: warn: FW ABI is more recent than kernel
[ 1811.281201] soundwire sdw-master-1: Slave Entry not found
[ 1811.281413] sof-audio-pci-intel-tgl 0000:00:1f.3: Topology: ABI 3:21:0 Kernel ABI 3:19:1
[ 1811.281424] sof-audio-pci-intel-tgl 0000:00:1f.3: warn: topology ABI is more recent than kernel
[ 1811.281527] sof-audio-pci-intel-tgl 0000:00:1f.3: error: can't connect DAI HDA3.OUT stream iDisp4
[ 1811.281536] sof-audio-pci-intel-tgl 0000:00:1f.3: error: failed to add widget id 0 type 27 name : HDA3.OUT stream iDisp4
[ 1811.281543] sof_sdw sof_sdw: ASoC: failed to load widget HDA3.OUT
[ 1811.281546] sof_sdw sof_sdw: ASoC: topology: could not load header: -22
[ 1811.281565] sof-audio-pci-intel-tgl 0000:00:1f.3: error: tplg component load failed -22
[ 1811.281578] sof-audio-pci-intel-tgl 0000:00:1f.3: error: failed to load DSP topology -22
[ 1811.281581] sof-audio-pci-intel-tgl 0000:00:1f.3: ASoC: error at snd_soc_component_probe on 0000:00:1f.3: -22
[ 1811.281609] sof_sdw sof_sdw: ASoC: failed to instantiate card -22
[ 1811.281955] sof_sdw sof_sdw: snd_soc_register_card failed -22
[ 1811.281958] sof_sdw: probe of sof_sdw failed with error -22
[ 1811.301675] soundwire sdw-master-0: Slave Entry not found

Describe the solution you'd like
It would be appreciated if add support for sof-adl-rt711-2ch.

Additional context
alsa-info log

Activity

  1. AlecJY
    added
    enhancementNew feature or request
    on Jun 28, 2022

  2. plbossart commented on Jun 28, 2022

    @plbossart
    plbossart
    on Jun 28, 2022
    Member

    @AlecJY unfortunately it's likely that we will need topology and machine driver changes to support this HP platform. It's not the first time this happens, it was the same mess with TigerLake.

    Can you please add this file
    sof-dyndbg.conf.txt
    as /etc/modprobe.d/sof-dyndbg.conf (the extension does matter), reboot and attach the entire dmesg log.

    If you can also add the result of

    ls /sys/bus/soundwire/devices/

    and

    cat /sys/bus/acpi/devices/*/adr  | grep 025d
  3. plbossart
    added
    codecCodec HW or driver restriction
    topologyIssues caused by topology
    on Jun 28, 2022

  4. AlecJY commented on Jun 28, 2022

    @AlecJY
    AlecJY
    on Jun 28, 2022
    Author

    dmesg.log

    And the result of the two commands

    $ ls /sys/bus/soundwire/devices/
sdw:0:025d:0711:00  sdw:0:025d:0711:01:0  sdw:3:025d:1316:01:0  sdw-master-0  sdw-master-1
    $ cat /sys/bus/acpi/devices/*/adr  | grep 025d
0x000020025d071100
0x000120025d071100

  5. plbossart commented on Jun 28, 2022

    @plbossart
    plbossart
    on Jun 28, 2022
    Member

    Thanks @AlecJY

    ok, so the BIOS/DSDT is completely wrong. HP declared the SAME rt711 (headset) on two links, but in reality it's really a rt711-sdca (new version!) on link0 and rt1316 on link1. What a complete fail.

    I'll prepare a set of patches but you'll have to compile your own kernel

  6. plbossart
    added 3 commits that reference this issue on Jun 28, 2022

    soundwire: dmi-quirks: add remapping for HP Omen 16-k0005TX

    a1152d1

    ASoC: Intel: soc-acpi: add table for HP Omen 16-k0005TX

    9961252

    ASoC: Intel: sof_sdw: add quirk for HP Omen 16-k0005TX

    46eef12

  7. plbossart commented on Jun 28, 2022

    @plbossart
    plbossart
    on Jun 28, 2022
    Member

    @AlecJY Please try the last three patches in #3725

    You will need do this as well, we'll release an update later on for topologies.

    cd /lib/firmware/intel/sof-tplg

cp sof-tgl-rt711-rt1308-2ch.tplg sof-adl-rt711-l0-rt1326-l1-2ch.tplg

  8. plbossart commented on Jun 28, 2022

    @plbossart
    plbossart
    on Jun 28, 2022
    Member

    @AlecJY if you don't know how to build the kernel, see https://thesofproject.github.io/latest/getting_started/setup_linux/prepare_build_environment.html and
    https://thesofproject.github.io/latest/getting_started/setup_linux/install_locally.html

  9. plbossart
    added a commit that references this issue on Jun 28, 2022

    ASoC: Intel: sof_sdw: add quirk for HP Omen 16-k0005TX

    efb3d34
  10. lgirdwood
    transferred this issue fromthesofproject/sofon Jun 29, 2022

  11. AlecJY commented on Jun 29, 2022

    @AlecJY
    AlecJY
    on Jun 29, 2022
    Author

    The soundcard still did not work, and there's nothing under /sys/bus/soundwire/devices/.

    dmesg.log
    alsa-info log

  12. plbossart commented on Jun 29, 2022

    @plbossart
    plbossart
    on Jun 29, 2022
    Member

    @AlecJY you seem to have a kernel configuration issue. Make sure that SOF is enabled. You can also use 'blacklist snd-hda-intel' to see what happens.

    Here are a set of configs you'll need:

    CONFIG_SND_SOC_INTEL_SOUNDWIRE_SOF_MACH=m
CONFIG_SND_SOC_SOF_TOPLEVEL=y
CONFIG_SND_SOC_SOF_PCI_DEV=m
CONFIG_SND_SOC_SOF_PCI=m
CONFIG_SND_SOC_SOF_ALDERLAKE=m
CONFIG_SND_SOC_SOF_HDA_COMMON=m
CONFIG_SND_SOC_SOF_HDA_LINK=y
CONFIG_SND_SOC_SOF_HDA_AUDIO_CODEC=y
CONFIG_SND_SOC_SOF_HDA_LINK_BASELINE=m
CONFIG_SND_SOC_SOF_HDA=m
CONFIG_SND_SOC_SOF_HDA_PROBES=m
CONFIG_SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE=m
CONFIG_SND_SOC_SOF_INTEL_SOUNDWIRE=m
CONFIG_REGMAP_SOUNDWIRE=m
CONFIG_REGMAP_SOUNDWIRE_MBQ=m
CONFIG_SND_INTEL_SOUNDWIRE_ACPI=m
CONFIG_SND_SOC_INTEL_SOUNDWIRE_SOF_MACH=m
CONFIG_SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE=m
CONFIG_SND_SOC_SOF_INTEL_SOUNDWIRE=m
CONFIG_SOUNDWIRE=m
CONFIG_SOUNDWIRE_CADENCE=m
CONFIG_SOUNDWIRE_INTEL=m
# CONFIG_SOUNDWIRE_QCOM is not set
CONFIG_SOUNDWIRE_GENERIC_ALLOCATION=m

  13. 61 remaining items

  14. plbossart commented on Jul 8, 2022

    @plbossart
    plbossart
    on Jul 8, 2022
    Member

    @shumingfan @bardliao I don't see this mixer value being set in UCM, and it's an SOF mixer value that should be set to 0dB on both channels. We need to fix this without asking people to play with amixer, otherwise other folks will have the same issue.

    Besides, we don't have any references to the PGA stuff any longer, see alsa-project/alsa-ucm-conf@b856040

  15. bardliao commented on Jul 11, 2022

    @bardliao
    bardliao
    on Jul 11, 2022
    Collaborator

    @plbossart We should set to 0dB for all platforms. Probable add a new file for SOF mixers in https://github.com/alsa-project/alsa-ucm-conf/tree/master/ucm2/Intel/SOF? @libinyang What do you think?

  16. plbossart commented on Jul 11, 2022

    @plbossart
    plbossart
    on Jul 11, 2022
    Member

    @ranj063 aren't those controls initialized by default to 0dB? Not sure why we would need an UCM file to alter the default that the topology should do already. Thanks!

  17. plbossart
    added 2 commits that reference this issue on Jul 11, 2022

    topology1: sof-tgl-rt711-rt1308: make amplifier link configuration

    4d212e3

    ASoC: Intel: sof_sdw: avoid oops in error handling

    6da6824
  18. lgirdwood
    added a commit that references this issue on Jul 12, 2022

    topology1: sof-tgl-rt711-rt1308: make amplifier link configuration

    e70fd0f
  19. plbossart
    added 2 commits that reference this issue on Jul 12, 2022

    ASoC: Intel: sof_sdw: avoid oops in error handling

    ad50d38

    ASoC: Intel: sof_sdw: avoid oops in error handling

    3baa90a
  20. ammarfaizi2
    added a commit that references this issue on Jul 15, 2022

    ASoC: Intel: sof_sdw: avoid oops in error handling

    8116483
  21. lgirdwood
    added a commit that references this issue on Aug 15, 2022

    topology1: sof-tgl-rt711-rt1308: make amplifier link configuration

    5c4204a

  22. plbossart commented on Sep 15, 2022

    @plbossart
    plbossart
    on Sep 15, 2022
    Member

    @AlecJY I am told there's a tentative fix available made available by the Quanta BIOS team at https://drive.google.com/file/d/1ZjX-Gvb_Zy948t2f44D4gXIiiXVZbdfp/view.

    If you are willing to give this update a try that would be appreciated. You may want to make sure you have a BIOS backup or something to go back to the previious solution should any problems occur.

  23. AlecJY commented on Sep 15, 2022

    @AlecJY
    AlecJY
    on Sep 15, 2022
    Author

    @plbossart I tried to update the BIOS with the utility. However, it showed this.

    image

    I also tried to install with recovery USB, but it showed another error message.

    image

  24. plbossart commented on Sep 16, 2022

    @plbossart
    plbossart
    on Sep 16, 2022
    Member

    Thanks @AlecJY. Quanta confirmed that end-users cannot install non 'formal' BIOS releases so they will have to do the validation. Sorry for the noise and thanks for your tests.

  25. shourove000 commented on Jun 16, 2023

    @shourove000
    shourove000
    on Jun 16, 2023

    354053927_292069906500188_4598077252978343396_n
    Equalizer is not available in headphone after reinstalling windows,, i updated the audio driver but still facing this problem,,, anyone please help.

  26. plbossart commented on Jun 16, 2023

    @plbossart
    plbossart
    on Jun 16, 2023
    Member

    354053927_292069906500188_4598077252978343396_n Equalizer is not available in headphone after reinstalling windows,, i updated the audio driver but still facing this problem,,, anyone please help.

    not an SOF bug, please see through HP/Windows support channels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    codecCodec HW or driver restrictionenhancementNew feature or requesttopologyIssues caused by topology

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions