Repository navigation
[BUG] Keyword detection trigger failure on WHL with S24_LE format #1615
Description
Describe the bug
This issue only happens on WHL when doing the wov testing, Sometimes detection cannot be triggered after clapping.
To Reproduce
Run below test command repeatedly
- arecord -Dhw:0,8 -M -N -f s24_le --period-size=400 -r 16000 -c 2 wov.wav -d 10 -vvv
- clap your hands to trigger the detection.
Reproduction Rate
Reprodcution rate is about 20%
Expected behavior
detection can be triggered properly.
Impact
Failed to trigger the detection for WOV.
Environment
- Kernel:
branch: topic/keyword-detect
commit/9c986c39d452e88cdf97bf3934b99265263a499e - Firmware
branch: top cml-005-drop-stable
commit: b8e53bc - Platform: WHL-RVP/I2S mode.
- Reproducibility Rate. 20%
Screenshots or console output
arecord -Dhw:0,8 -M -N -f s24_le --period-size=400 -r 16000 -c 2 wov.wav -d 10 -vvv
MobaXterm X11 proxy: Authorisation not recognised
xcb_connection_has_error() returned true
Recording WAVE 'wov.wav' : Signed 24 bit Little Endian, Rate 16000 Hz, Stereo
Hardware PCM card 0 'sof-sof_rt5682' device 8 subdevice 0
Its setup is:
stream : CAPTURE
access : MMAP_INTERLEAVED
format : S24_LE
subformat : STD
channels : 2
rate : 16000
exact rate : 16000 (16000/1)
msbits : 32
buffer_size : 6528
period_size : 408
period_time : 25500
tstamp_mode : NONE
tstamp_type : MONOTONIC
period_step : 1
avail_min : 408
period_event : 0
start_threshold : 1
stop_threshold : 6528
silence_threshold: 0
silence_size : 0
boundary : 7349874591868649472
appl_ptr : 0
hw_ptr : 0
mmap_area[0] = 0x7f3d9b912000,0,64 (32)
mmap_area[1] = 0x7f3d9b912000,32,64 (32)
Activity
mrajwa commentedon Jul 9, 2019
I will handle this one.
mrajwa commentedon Jul 16, 2019
@keqiaozhang, the release branch has been updated regarding this issue.
keyonjie commentedon Jul 16, 2019
keqiaozhang commentedon Jul 17, 2019
@mrajwa
I tried the latest release branch, but this issue is still reproducible on both cml and whl-rvp.
Firmware info:
b85c320
trace
logger-t.txt
keqiaozhang commentedon Jul 18, 2019
@mrajwa
Looks like this issue only occurs when testing S24_LE format. No such issue when testing S16_LE format.
mrajwa commentedon Jul 19, 2019
@keqiaozhang, I have provided patch for this on release branch. Please verify if it solved the issue.
hualongfeng commentedon Jul 22, 2019
I test the the latest release branch(d6335a4) on cml chromebook, this issue is still reproducible.
The below is test script. And when the issue occur, the following are not trigger unless wait 3 second.
#!/bin/bash
rm -r ~/Desktop/test/*
for (( i=1; i <= 100; i++ ))
do
arecord -Dhw:0,8 -M -N -f S24_LE --period-size=400 -r 16000 -c 2 ~/Desktop/test/wov$i.wav -d 10 -vvv
sleep 1
done
YvonneYang2 commentedon Jul 22, 2019
Test it on WHL-I2S with test recipe as below, issue still can reproduced.
The frequency : 1/5 1/7 1/2
Test recipe:
Firmware: d6335a4 https://github.com/thesofproject/sof/commits/cml-005-drop-stable
Kernel: 9c986c3 https://github.com/thesofproject/linux/commits/topic/keyword_dete
hualongfeng commentedon Jul 23, 2019
This is error tips on firmware branch(6335a4).
error.txt
mrajwa commentedon Jul 25, 2019
@keqiaozhang @YvonneYang2 @hualongfeng, it's because I missed some related patches, sorry about that. They are pushed now, so please test again.
2 remaining items
YvonneYang2 commentedon Jul 26, 2019
Update #1615 (comment). test 150 times with s16_le format cannot reproduce the bug, but can still reproduce the issue with s24_le format.
Reproduce rate: 1/17
log_17.txt
mrajwa commentedon Jul 26, 2019
@keqiaozhang @YvonneYang2, logs doesn't say much, can I have dmesg. Also, how often does it happen? If there is no detection I assume you terminate arecord and start again, then can you trigger?
YvonneYang2 commentedon Jul 26, 2019
Set the interval time between terminate arecord and start as 10s, issue occurred at 43rd with s24_le format.
If no detection occurred, terminate it and start, can work again. Logs please see work_again.txt.
logger43.log
work_again_dmesg.txt
work_again_logger.txt
dmesg_42.log
dmesg_43.log
logger_42.log
mrajwa commentedon Jul 30, 2019
@YvonneYang2, @keqiaozhang please retest with https://github.com/thesofproject/sof/tree/cml-007-drop-stable
YvonneYang2 commentedon Jul 31, 2019
Issue still reproduced with test recipe as below. Meanwhile, arecord status will stuck during test. Sometimes, arecord stuck issue will block the trigger issue validation.
Reproduce rate:
Trigger issue: 1/11
arecord stuck: 1/5
Test recipe:
Firmware: 442cfb2 https://github.com/thesofproject/sof/commits/cml-007-drop-stable
Kernel: f267c3d https://github.com/thesofproject/linux/commits/topic/keyword_detect
Topology:file: sof-cml-rt5682.tplg link from sof-whl-rt5682-kwd.tplg
platform: whl-i2s
arecord_stuck_error_logger.txt
arecord_stuck_logger.txt
arecord_stuck_dmesg.txt
trigger_dmesg.txt
trigger_logger.txt
YvonneYang2 commentedon Jul 31, 2019
Arecord stuck issue will track in #1692
[-][BUG] Keyword detection trigger failure on WHL[/-][+][BUG] Keyword detection trigger failure on WHL with S24_LE format[/+]mrajwa commentedon Sep 2, 2019
This issue should be finally fixed by #1768, @keqiaozhang please verify on your side.
YvonneYang2 commentedon Sep 3, 2019
Issue is blocked by #1775 , so cannot verify it now.
mrajwa commentedon Sep 3, 2019
@YvonneYang2, can you test cml-007-drop-stable, with #1768 merged into?
keqiaozhang commentedon Sep 3, 2019
@mrajwa
I tried to manually apply your PR1768 on 007 stable branch, but failed, there're some hard conflicts, please check the src/audio/pipeline.c, "flags" is still in used and can not be removed, so I keep the flags definition and run test on WHL, this issue still can be reproduced with 100%, even the S16_LE format.
YvonneYang2 commentedon Sep 4, 2019
Test it 200 times on WHL platform with recipe as below, issue cannot reproduce.
FW: master branch 90873c5 + #1689 + #1740 + #1768
Kernel: topic/sof-dev branch f95e4eb + PR1037
aiChaoSONG commentedon Sep 4, 2019
Test it 200 times on CML Chrome with recipe as below, issue cannot reproduce too.
FW: master branch 90873c5 + #1689 + #1740 + #1768
Kernel: topic/sof-dev branch f95e4eb + PR1037