Repository navigation
kwd: improvements - #1689
Merged
Merged
kwd: improvements#1689
Conversation
jajanusz
approved these changes
Jul 30, 2019
tlauda
suggested changes
Jul 31, 2019
tlauda
left a comment
tlauda
left a comment
Contributor
There was a problem hiding this comment.
Typo in second commit message.
lgirdwood
approved these changes
Aug 2, 2019
Contributor
|
@mrajwa Can you fix the typo in second commit message, co we could merge this? |
This patch changes the datatype of timeout variable and adds more information into error log message. Also we set up timeout limit right before we enter the while loop. Signed-off-by: Marcin Rajwa <marcin.rajwa@linux.intel.com>
This patch improves kpb_reset() log message by adding the state from which we start resetting. Signed-off-by: Marcin Rajwa <marcin.rajwa@linux.intel.com>
This patch adds state to the error log message of kpb_copy() function. Signed-off-by: Marcin Rajwa <marcin.rajwa@linux.intel.com>
Contributor
Author
|
@tlauda @lgirdwood @jajanusz , PR updated with new patches. |
tlauda
suggested changes
Sep 2, 2019
Contributor
Author
There was a problem hiding this comment.
Wider data size gives us the possibility to log more states. So I would keep it as 64 bits.
Contributor
There was a problem hiding this comment.
Space at the end not needed.
Contributor
There was a problem hiding this comment.
The last sentence of the commit description seems weird.
Contributor
Author
There was a problem hiding this comment.
Yes, during host copy we no longer need selector and detector components.
Contributor
Author
|
@tlauda, updated. |
tlauda
approved these changes
Sep 5, 2019
Contributor
|
@mrajwa Can you fix the checkpatch? |
This patch adds a container of KPB statuses. So every time KPB changes its status it can also log that change. In case of any error this log of status changes can be read back providing nice history of KPB actions. Signed-off-by: Marcin Rajwa <marcin.rajwa@linux.intel.com>
This patch replaces all explicit kpb state changes via a call to dedicated interface which in the same time also logs the change in the internal logger. Signed-off-by: Marcin Rajwa <marcin.rajwa@linux.intel.com>
This patch adds history of status changes into some important error logs. Thanks to this, in case of some serious failure we can check how KPB was changing its state prior to failure. Signed-off-by: Marcin Rajwa <marcin.rajwa@linux.intel.com>
This patch checks during prepare we managed to find KPB's sinks. Signed-off-by: Marcin Rajwa <marcin.rajwa@linux.intel.com>
This patch improves KPB reset handling by adding explicit state handling. Signed-off-by: Marcin Rajwa <marcin.rajwa@linux.intel.com>
This patch fixes the bug of zero buffering size during draining. Signed-off-by: Marcin Rajwa <marcin.rajwa@linux.intel.com>
This patch checks if "copy_bytes" which is the minimum of sink->free and source->avail is != 0. If so we go further with copy and internal buffering. If no we log error message and return from copy function. Signed-off-by: Marcin Rajwa <marcin.rajwa@linux.intel.com>
This patch fixes state change in buffering function before the check of state from previous stage. This issue resulted in missing samples from stream during draining. Signed-off-by: Marcin Rajwa <marcin.rajwa@linux.intel.com>
Contributor
Author
|
@tlauda, sure I have just done it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds some improvements aimed to extend KPB logging
by providing informations like kpb state or timeout duration.
Signed-off-by: Marcin Rajwa marcin.rajwa@linux.intel.com