Repository navigation
ipc: align stream.h with kernel - #1740
Merged
Merged
Conversation
This change is to align sof_ipc_stream_params with its kernel equivalent. In this patch no_stream_position parameter is added to relax host_period_bytes from storing information about the need of stream position update. Signed-off-by: Marcin Rajwa <marcin.rajwa@linux.intel.com>
This patch fixes the incorrect check for host_period_bytes. This value was incorrectly used to store host request for stream position. After we introduced dedicated parameter for this purpose (no_stream_position) the check needs to be updated accordingly. Therefore this patch adds a check for no_stream_position rather than host_period_bytes to decide if stream position shall be send. Signed-off-by: Marcin Rajwa <marcin.rajwa@linux.intel.com>
mrajwa
requested review from
a team,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
August 22, 2019 12:16
jajanusz
approved these changes
Aug 26, 2019
tlauda
approved these changes
Aug 27, 2019
lgirdwood
approved these changes
Aug 30, 2019
Member
|
@zrombel @xiulipan I'm not seeing @YvonneYang2 build failure in the CI errors..... |
Member
Guys ignore the build failure report, it's a runtime failure with GCC and I've renamed the issue. |
|
SOFCI TEST |
1 similar comment
|
SOFCI TEST |
|
ping. Should this be merged? @lgirdwood @tlauda |
Member
|
This should be tied to an ABI change, and the kernel patches need to handle the backwards compatibility. |
Contributor
Author
|
@plbossart, can we merge now? Kernel part is already merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes the incorrect check for
host_period_bytes. This value was incorrectly used
to store host request for stream position. So
we introduced dedicated parameter for this purpose
(no_stream_position) and update all related checks accordingly.