Repository navigation
kernel-log-check: revise ignore_str for usb errors. - #595
Conversation
bus 2, check
No this would ignore absolutely all USB errors, including from USB audio devices (e.g. #593) and from USB network devices that we use. |
xiulipan
left a comment
There was a problem hiding this comment.
Then I think we filter all hub issues and some usb issues
|
Let's first stabilize the current test results with small, careful and focused changes. Once the filters have not changed for a while then we can start from a "steady green base" and look at refactorings, cleanups and other simplifications. Continuous Integration = small changes spread over time. |
|
@marc-hb I see nothing with CI, are you good to merge this? |
|
@aiChaoSONG there is git conflict now, probably because I just merged #624 sorry. Should be small. |
734a6cf
|
@marc-hb rebased, thanks. |
| ignore_str="$ignore_str"'|hub 2-.: .' | ||
| ignore_str="$ignore_str"'|usb 2-.: .' | ||
| ignore_str="$ignore_str"'|hub [23]-.+' | ||
| ignore_str="$ignore_str"'|usb [23]-.+: Failed to suspend device, error' |
There was a problem hiding this comment.
I think the first line ignores everything that the second line does, so the second line is pointless.
The first line has two issues: 1. it ignores all USB errors on devices 2-9: ..., it ignores zero error on devices like 2-10: ...
As we want to ignore all hub error but not all usb errors, ...
I don't think there is any concept of "hub error" vs "other errors", all errors are prefixed the same.
Can you please ignore only the errors reported in #431 ?
A dot(.) can only match to a single character, so the fix 2253062 for sof-test#431 doesn't work. Fixes: thesofproject#431 Signed-off-by: Chao Song <chao.song@linux.intel.com>
This patch revises ignore_str for a new USB error: - usb 2-4.1: Disable of device-initiated U1 failed. - usb 2-4.1: Disable of device-initiated U2 failed. Signed-off-by: Chao Song <chao.song@linux.intel.com>
|
The third-party issues are not seen even this is not merged, close. |
Fixes: #431 #514