Skip to content

kernel-log-check: revise ignore_str for usb errors. - #595

Merged
aiChaoSONG merged 2 commits into
thesofproject:mainfrom
aiChaoSONG:usb
Jun 7, 2021
Merged

aiChaoSONG merged 2 commits into
thesofproject:mainfrom
aiChaoSONG:usb

Conversation

@aiChaoSONG

@aiChaoSONG aiChaoSONG commented Jan 27, 2021 •

Copy link
Copy Markdown

Fixes: #431 #514

@aiChaoSONG
aiChaoSONG requested a review from a team as a code owner January 27, 2021 03:21

@xiulipan xiulipan left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting here, what is the 2- means here? USB 2 or USB bus 2?
Do we want to ignore all USB 2 and 3 issues?

better with

ignore_str="$ignore_str"'|hub [23]+-.+:'
ignore_str="$ignore_str"'|usb [23]+-.+:'

And remove all other duplicate filters

Comment thread tools/sof-kernel-log-check.sh Outdated
@marc-hb

marc-hb commented Jan 27, 2021

Copy link
Copy Markdown
Collaborator

Interesting here, what is the 2- means here? USB 2 or USB bus 2?

bus 2, check lsusb -tv

ignore_str="$ignore_str"'|usb [23]+-.+:'

No this would ignore absolutely all USB errors, including from USB audio devices (e.g. #593) and from USB network devices that we use.

Comment thread tools/sof-kernel-log-check.sh
xiulipan
xiulipan previously approved these changes Jan 27, 2021

@xiulipan xiulipan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I think we filter all hub issues and some usb issues

@marc-hb

marc-hb commented Jan 27, 2021 •

Copy link
Copy Markdown
Collaborator

Let's first stabilize the current test results with small, careful and focused changes. Once the filters have not changed for a while then we can start from a "steady green base" and look at refactorings, cleanups and other simplifications.

Continuous Integration = small changes spread over time.

@xiulipan

Copy link
Copy Markdown
Contributor

@marc-hb I see nothing with CI, are you good to merge this?

plbossart
plbossart previously approved these changes Mar 4, 2021
marc-hb
marc-hb previously approved these changes Mar 4, 2021
@marc-hb

marc-hb commented Mar 6, 2021

Copy link
Copy Markdown
Collaborator

@aiChaoSONG there is git conflict now, probably because I just merged #624 sorry. Should be small.

@aiChaoSONG

Copy link
Copy Markdown
Author

@marc-hb rebased, thanks.

ignore_str="$ignore_str"'|hub 2-.: .'
ignore_str="$ignore_str"'|usb 2-.: .'
ignore_str="$ignore_str"'|hub [23]-.+'
ignore_str="$ignore_str"'|usb [23]-.+: Failed to suspend device, error'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the first line ignores everything that the second line does, so the second line is pointless.

The first line has two issues: 1. it ignores all USB errors on devices 2-9: ..., it ignores zero error on devices like 2-10: ...

As we want to ignore all hub error but not all usb errors, ...

I don't think there is any concept of "hub error" vs "other errors", all errors are prefixed the same.

Can you please ignore only the errors reported in #431 ?

Chao Song added 2 commits March 9, 2021 13:10
A dot(.) can only match to a single character,
so the fix 2253062 for sof-test#431 doesn't work.

Fixes: thesofproject#431

Signed-off-by: Chao Song <chao.song@linux.intel.com>
This patch revises ignore_str for a new USB error:
  - usb 2-4.1: Disable of device-initiated U1 failed.
  - usb 2-4.1: Disable of device-initiated U2 failed.

Signed-off-by: Chao Song <chao.song@linux.intel.com>
@aiChaoSONG

aiChaoSONG commented May 24, 2021 •

Copy link
Copy Markdown
Author

The third-party issues are not seen even this is not merged, close.

@aiChaoSONG aiChaoSONG closed this May 24, 2021
@aiChaoSONG aiChaoSONG reopened this Jun 7, 2021
@aiChaoSONG
aiChaoSONG merged commit d3f2189 into thesofproject:main Jun 7, 2021
@marc-hb marc-hb added area:non-audio Failure False positives: failing when we don't want to area:dmesg filter labels Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:non-audio Failure False positives: failing when we don't want to

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CHT] suspend-resume fails due to unrelated USB error

5 participants