Skip to content

kernel-log-check: revise ignore_str for usb errors. #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aiChaoSONG merged 2 commits into from
Jun 7, 2021
Merged

kernel-log-check: revise ignore_str for usb errors. #595

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd61d00
kernel-log-check: revise ignore_str for usb hub
Mar 8, 2021
61a1f39
kernel-log-check: revise ignore_str for new USB error
Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions tools/sof-kernel-log-check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,7 @@ ignore_str="$ignore_str"'|tpm tpm0: tpm_try_transmit: send\(\): error -5'
ignore_str="$ignore_str"'|platform regulatory\.0: Direct firmware load for regulatory\.db failed with error -2'
ignore_str="$ignore_str"'|cfg80211: failed to load regulatory\.db'
ignore_str="$ignore_str"'|EXT4-fs \(nvme0n1p6\): re-mounted\. Opts: errors=remount-ro'
ignore_str="$ignore_str"'|usb 2-3: Enable of device-initiated U1 failed\.'
ignore_str="$ignore_str"'|usb 2-3: Enable of device-initiated U2 failed\.'
ignore_str="$ignore_str"'|usb .+: (Enable|Disable) of device-initiated .+ failed\.'
Comment thread
aiChaoSONG marked this conversation as resolved.
ignore_str="$ignore_str"'|thermal thermal_zone.*: failed to read out thermal zone \(-61\)'

# Dell CML-U laptop with SoundWire, issues reported by sof-test
Expand All @@ -189,8 +188,8 @@ ignore_str="$ignore_str"'|\[drm:drm_dp_send_link_address \[drm_kms_helper\]\] \*

# CHT devices with USB hub, issues reported by sof-test
# BugLink: https://github.com/thesofproject/sof-test/issues/431
ignore_str="$ignore_str"'|hub 2-.: .'
ignore_str="$ignore_str"'|usb 2-.: .'
ignore_str="$ignore_str"'|hub [23]-.+: hub_ext_port_status failed'
ignore_str="$ignore_str"'|usb [23]-.+: Failed to suspend device, error'

@marc-hb marc-hb Mar 9, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the first line ignores everything that the second line does, so the second line is pointless.

The first line has two issues: 1. it ignores all USB errors on devices 2-9: ..., it ignores zero error on devices like 2-10: ...

As we want to ignore all hub error but not all usb errors, ...

I don't think there is any concept of "hub error" vs "other errors", all errors are prefixed the same.

Can you please ignore only the errors reported in #431 ?


# TGL devices with USB 3.1 devices, issues reported by sof-test
# BugLink: https://github.com/thesofproject/sof-test/issues/482
Expand Down